Skip to content

fix: remeasure virtualized rows after scroll restore #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlejandroAkbal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remeasure virtualized rows after scroll restore #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 53 additions & 3 deletions pages/posts/[domain].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,10 +572,16 @@

const parentRef = ref<HTMLElement | null>(null)
const parentOffsetRef = ref(0)
let scrollRestoreRemeasureTimeout: ReturnType<typeof setTimeout> | null = null

onMounted(() => {
parentOffsetRef.value = parentRef.value?.offsetTop ?? 0
})
function clearScrollRestoreRemeasureTimeout() {
if (scrollRestoreRemeasureTimeout == null) {
return
}

clearTimeout(scrollRestoreRemeasureTimeout)
scrollRestoreRemeasureTimeout = null
}

const rowVirtualizerOptions = computed(() => {
return {
Expand Down Expand Up @@ -647,6 +653,50 @@
})
}

function remeasureAfterScrollRestore() {
if (!import.meta.client || window.scrollY === 0) {
return
}

clearScrollRestoreRemeasureTimeout()

nextTick(() => {
rowVirtualizer.value.measure()

requestAnimationFrame(() => {
rowVirtualizer.value.measure()

scrollRestoreRemeasureTimeout = setTimeout(() => {
rowVirtualizer.value.measure()
scrollRestoreRemeasureTimeout = null
}, 250)
})
})
}

function onPageShow() {
remeasureAfterScrollRestore()
}

onMounted(() => {
parentOffsetRef.value = parentRef.value?.offsetTop ?? 0

remeasureAfterScrollRestore()
window.addEventListener('pageshow', onPageShow)
})

onBeforeUnmount(() => {
clearScrollRestoreRemeasureTimeout()
window.removeEventListener('pageshow', onPageShow)
})

watch(
() => allRows.value.length,
() => {
remeasureAfterScrollRestore()
}
)

/**
* SEO
*/
Expand Down
56 changes: 53 additions & 3 deletions pages/premium/saved-posts/[domain].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,10 +474,16 @@

const parentRef = ref<HTMLElement | null>(null)
const parentOffsetRef = ref(0)
let scrollRestoreRemeasureTimeout: ReturnType<typeof setTimeout> | null = null

onMounted(() => {
parentOffsetRef.value = parentRef.value?.offsetTop ?? 0
})
function clearScrollRestoreRemeasureTimeout() {
if (scrollRestoreRemeasureTimeout == null) {
return
}

clearTimeout(scrollRestoreRemeasureTimeout)
scrollRestoreRemeasureTimeout = null
}

const rowVirtualizerOptions = computed(() => {
return {
Expand Down Expand Up @@ -549,6 +555,50 @@
})
}

function remeasureAfterScrollRestore() {
if (!import.meta.client || window.scrollY === 0) {
return
}

clearScrollRestoreRemeasureTimeout()

nextTick(() => {
rowVirtualizer.value.measure()

requestAnimationFrame(() => {
rowVirtualizer.value.measure()

scrollRestoreRemeasureTimeout = setTimeout(() => {
rowVirtualizer.value.measure()
scrollRestoreRemeasureTimeout = null
}, 250)
})
})
}

function onPageShow() {
remeasureAfterScrollRestore()
}

onMounted(() => {
parentOffsetRef.value = parentRef.value?.offsetTop ?? 0

remeasureAfterScrollRestore()
window.addEventListener('pageshow', onPageShow)
})

onBeforeUnmount(() => {
clearScrollRestoreRemeasureTimeout()
window.removeEventListener('pageshow', onPageShow)
})

watch(
() => allRows.value.length,
() => {
remeasureAfterScrollRestore()
}
)

/**
* SEO
*/
Expand Down