-
Notifications
You must be signed in to change notification settings - Fork 0
feat: member update API #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Coverage Report
|
|
|
||
| public record MemberInfoRequest( | ||
| @Nullable | ||
| @Schema(description = "성별", example = "FEMALE / MALE", nullable = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성별은 변경 안되는거 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 피그마보고 한건데 그럼 디자이너 분들께 성별은 빼달라고 말할게요..!
| @Transactional | ||
| public void updateMemberInfo(Member member, String imageStatus, MultipartFile image, MemberInfoRequest data) { | ||
|
|
||
| switch (imageStatus) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔꼼하다👍
|
지금은 간단하지만 조금 더 복잡한 로직이 나오면 그때 뭘 테스트 해야할 지 작성한 본인이 제일 잘 알지 않을까요! |
오호..알겠습니다 |
✨ 연관된 이슈
📝 작업 내용 (주요 변경 사항)
💬 리뷰 요구사항
테스트코드에서 뭘 검증하면 좋을지 아직 잘 모르겠어요 ,,