Skip to content

Conversation

@west-eastH
Copy link
Contributor

✨ 연관된 이슈

아직


📝 작업 내용 (주요 변경 사항)

  • 현재 로그인한 멤버가 속한 크루 주입 어노테이션 @MemberCrew 추가
  • 시간 측정 어노테이션 @logging 추가
  • 일정 생성 API - 운영진(크루장)만 가능

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

일정이랑 러닝캡 연관관계 OneToOne -> ManyToOne으로 변경
(ddl-auto 옵션 배포환경에 적용해야돼서 create로 변경했는데 다음 PR에서 update로 변경 부탁드려요~)

@west-eastH west-eastH requested a review from choiseoji July 18, 2025 07:20
@west-eastH west-eastH self-assigned this Jul 18, 2025
@west-eastH west-eastH added the ✨feat 기능 개발 시 label Jul 18, 2025
@west-eastH west-eastH linked an issue Jul 18, 2025 that may be closed by this pull request
8 tasks
@github-actions
Copy link

Test Coverage Report

Overall Project 61.1% -1.51% 🍏
Files changed 86.98% 🍏

File Coverage
EventServiceImpl.java 100% 🍏
EventException.java 100% 🍏
EventErrorCode.java 100% 🍏
EventCreationValidationDto.java 100% 🍏
PeriodicEvent.java 100% 🍏
JoinEvent.java 100% 🍏
EventInfoRequest.java 100% 🍏
Member.java 92% -8%
Event.java 77.78% -22.22% 🍏
EventController.java 0%

Copy link
Contributor

@choiseoji choiseoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~!!

private final EventServiceImpl eventService;

@PostMapping
@PreAuthorize("hasRole('MANAGER') or hasRole('LEADER')")
Copy link
Contributor

@choiseoji choiseoji Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오!!! 이거 완전 좋네요!!
이거 하면 시큐리티 파일에서 따로 API 경로로 권한 검사 안해줘도 되는거죠??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아요~

@west-eastH west-eastH merged commit eaa260e into develop Jul 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feat 기능 개발 시

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨feat : event API

3 participants