-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: 유저 이번 시즌 러닝 조회 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Test Coverage Report
|
choiseoji
approved these changes
Aug 10, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!
EventResponseDto..? 이벤트 뜻하는 이름으로 바꿀까요?
Comment on lines
32
to
38
| @Query("SELECT new run.backend.domain.crew.dto.response.EventProfileResponse(" + | ||
| "e.id, e.title, e.date, e.startTime, e.endTime, e.expectedParticipants) " + | ||
| "FROM JoinEvent j JOIN j.event e " + | ||
| "WHERE j.member = :member " + | ||
| "AND e.date >= :startDate AND e.date <= :endDate " + | ||
| "AND e.status = 'COMPLETED' ORDER BY e.date DESC") | ||
| List<EventProfileResponse> findMonthlyCompletedEvents(@Param("member") Member member, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" 이거 3번 쓰면
'+' 안 사용하고 쿼리 쭉 쓸 수 있어요!
Test Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 연관된 이슈
📝 작업 내용 (주요 변경 사항)
💬 리뷰 요구사항
러닝 리스트 응답이 CrewUpcomingEventResponse 이거랑 같아서 우선 이걸로 썼는데 따로 만들까요?
아니면 이름을 공통으로 사용할 수 있게 변경하는게 좋을까요?