Skip to content

Conversation

@west-eastH
Copy link
Contributor

✨ 연관된 이슈

close #33


📝 작업 내용 (주요 변경 사항)

  • 유저의 이번 시즌 참여 횟수 조회 API
  • 유저의 이번 시즌 참여 러닝 리스트 조회 API

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

러닝 리스트 응답이 CrewUpcomingEventResponse 이거랑 같아서 우선 이걸로 썼는데 따로 만들까요?
아니면 이름을 공통으로 사용할 수 있게 변경하는게 좋을까요?

@west-eastH west-eastH requested a review from choiseoji August 10, 2025 05:53
@west-eastH west-eastH self-assigned this Aug 10, 2025
@west-eastH west-eastH added the ✨feat 기능 개발 시 label Aug 10, 2025
@west-eastH west-eastH linked an issue Aug 10, 2025 that may be closed by this pull request
2 tasks
@github-actions
Copy link

Test Coverage Report

Overall Project 53.08% -0.52% 🍏
Files changed 79.63% 🍏

File Coverage
JoinEvent.java 100% 🍏
MemberParticipatedCountResponse.java 100% 🍏
EventService.java 93.09% 🍏
MemberService.java 71.11% 🍏
PeriodicEvent.java 42.25% 🍏
MemberController.java 0% -39.29%

Copy link
Contributor

@choiseoji choiseoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!
EventResponseDto..? 이벤트 뜻하는 이름으로 바꿀까요?

Comment on lines 32 to 38
@Query("SELECT new run.backend.domain.crew.dto.response.EventProfileResponse(" +
"e.id, e.title, e.date, e.startTime, e.endTime, e.expectedParticipants) " +
"FROM JoinEvent j JOIN j.event e " +
"WHERE j.member = :member " +
"AND e.date >= :startDate AND e.date <= :endDate " +
"AND e.status = 'COMPLETED' ORDER BY e.date DESC")
List<EventProfileResponse> findMonthlyCompletedEvents(@Param("member") Member member,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" 이거 3번 쓰면
'+' 안 사용하고 쿼리 쭉 쓸 수 있어요!

@github-actions
Copy link

Test Coverage Report

Overall Project 53.08% -0.64% 🍏
Files changed 78.23% 🍏

File Coverage
CrewEventService.java 100% 🍏
JoinEvent.java 100% 🍏
MemberParticipatedCountResponse.java 100% 🍏
EventResponseDto.java 100% 🍏
EventService.java 93.09% 🍏
MemberService.java 71.11% 🍏
PeriodicEvent.java 42.25% 🍏
CrewController.java 0% -3.11%
MemberController.java 0% -39.29%

@west-eastH west-eastH merged commit d49418e into develop Aug 10, 2025
1 check passed
@west-eastH west-eastH deleted the feat/33-season-running branch August 10, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feat 기능 개발 시

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨feat : 이번 시즌 러닝 조회 API

3 participants