Skip to content

Conversation

@choiseoji
Copy link
Contributor

✨ 연관된 이슈

close #39


📝 작업 내용 (주요 변경 사항)

  • 실제 좌표를 받아서 (0,0) ~ (1000, 1000) 내의 픽셀로 변환하는 로직 => 동적 생성
  • 기존 픽셀이 존재한다면 현재 크루와 비교하여 timestamp가 더 늦은 크루의 id로 저장

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Pixel 엔티티에 Crew 직접 참조가 아닌 crew_id 만 저장하도록 했는데..이거 어떻게 생각하시나요?

@choiseoji choiseoji requested a review from west-eastH October 18, 2025 14:15
@choiseoji choiseoji self-assigned this Oct 18, 2025
@choiseoji choiseoji added the ✨feat 기능 개발 시 label Oct 18, 2025
@choiseoji choiseoji linked an issue Oct 18, 2025 that may be closed by this pull request
1 task
@github-actions
Copy link

Test Coverage Report

Overall Project 51.53% -4.3% 🍏
Files changed 0%

File Coverage
Pixel.java 0%
PixelId.java 0%
Coordinate.java 0%
RunningErrorCode.java 0%
RunningException.java 0%
RunningService.java 0%
RunningController.java 0%

Copy link
Contributor

@west-eastH west-eastH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생하셨습니다 DB는 그냥 그대로 쓰는건가요?

@choiseoji
Copy link
Contributor Author

굿굿 고생하셨습니다 DB는 그냥 그대로 쓰는건가요?

NoSQL이랑 파이썬 사용하면 트랜잭션 처리가 조금 까다로울거 같아서 그냥 그대로를 선택했습니당ㅅ..

@github-actions
Copy link

Test Coverage Report

Overall Project 55.76% -0.9% 🍏
Files changed 83.71% 🍏

File Coverage
Pixel.java 100% 🍏
PixelId.java 100% 🍏
Coordinate.java 100% 🍏
RunningService.java 93.22% -6.78% 🍏
RunningErrorCode.java 0%
RunningException.java 0%
RunningController.java 0%

@choiseoji
Copy link
Contributor Author

좋은데요!?

@choiseoji choiseoji merged commit 74f2bd2 into develop Nov 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feat 기능 개발 시

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨feat : 좌표 저장

3 participants