Implement interactive chat mode with user authentication by chojuninengu · Pull Request #33 · Rust-Cameroon/async-chat

chojuninengu · 2025-04-07T09:33:33Z

This PR implements an interactive chat mode with user authentication, addressing issue #1.

Changes include:

Added user authentication (register/login)
Implemented interactive chat mode
Added proper message formatting with usernames
Fixed connection handling for authenticated users

To test:

Start the server: cargo run --bin server 127.0.0.1:8080
Join a chat: cargo run --bin client 127.0.0.1:8080 chat -g general -u your_username

…uthentication

…uthentication responses

…n and session management

Dericko681 · 2025-04-07T12:37:14Z

@chojuninengu great job but a quick question; Does this code compile locally?

tips: resolve all conflicts with the main

chojuninengu · 2025-04-07T12:42:39Z

@Dericko681 , it does compile locally

Dericko681 · 2025-04-07T12:50:37Z

@chojuninengu Oh great, I just figured out, update the start server command in the description of this PR to cargo run --bin server 127.0.0.1:8080

chojuninengu · 2025-04-07T12:53:32Z

@Dericko681 , thanks for that update
i just did now,

ndefokou · 2025-04-07T15:32:40Z

Hello @chojuninengu, great work! However, please add the Cargo.lock file to the .gitignore — it shouldn't be committed to the repository.
Also, kindly resolve the merge conflicts on your branch.

chojuninengu · 2025-04-07T15:40:12Z

@ndefokou , thanks for the remark, i just resolved it

sinke237 · 2025-04-07T16:19:02Z

@chojuninengu just to leave a remark that if the pipeline is failing, you want to fix it before requiring a review.
Secondly, why merge main into your branch. there is a develop branch? this is the root for all feature branches
The main branch will be used to release the stable versions of the code.
Best practices:

Create feature branch from develop
rebase to develop in cases of conflict

…iguration

…g to be asynchronous

…hronous access

chojuninengu · 2025-04-07T20:52:03Z

@Christiantyemele , please can you see into this issue, cuz this is the only thing that is holding my for now

Dericko681

hey @chojuninengu you are doing an amazing job here but you can't modify unrelated files .github/workflows/ci.yml in this same PR. There is an open issue #34 which is debating how to fix the issue with failing CI/CD

.github/workflows/ci.yml

Christiantyemele · 2025-04-08T07:15:56Z

src/bin/client.rs

+    Chat {
+        /// Name of the group to chat in
+        #[arg(short, long)]
+        group: String,
+        /// Username to use
+        #[arg(short, long)]
+        username: String,
+    },


i don't understand the function of this field, elaborate. cause from what i try to understand you want creating a join a group to be seperate task that is i create a group with a password then share the password to those i want them to join the group in that case then this your Chat field here is not clear in its naming convenction and the values it holds too. cause i don't see the different between Post and Chat when reading their names

Christiantyemele · 2025-04-08T07:18:00Z

src/bin/client.rs

+                // First register/login the user
+                let register_command = FromClient::Register {
+                    username: Arc::new(username.clone()),
+                    password: Arc::new("password".to_string()), // TODO: Add proper password handling


if this is too big for you to handle plz just create a ticket in other not to forget

Christiantyemele · 2025-04-08T07:24:54Z

src/bin/client.rs

+                let join_command = FromClient::Join {
+                    group_name: Arc::new(group.clone()),


what is the essence of creating a group with a password if i don't join using that password, unless it's for future implementation ?

Christiantyemele · 2025-04-08T07:35:18Z

src/bin/client.rs

+        let command = FromClient::Post {
+            group_name: Arc::new(group.clone()),
+            message: Arc::new(input.to_string()),
+        };
+
+        utils::send_as_json(&mut socket, &command).await?;
+        socket.flush().await?;
+    }
+


You see what i was saying here you call Post in Chat but still have a seperate handler for posting so what is the difference in the two ?

Christiantyemele · 2025-04-08T07:39:38Z

src/bin/server/user.rs

+        }
+    }
+
+    pub async fn register(&self, username: Arc<String>) -> anyhow::Result<User> {


i don't see the use of putting username here in an Arc

Christiantyemele · 2025-04-08T07:42:52Z

src/bin/server/user.rs

+        let user = User {
+            username: username.clone(),
+            id: Arc::new(Uuid::new_v4().to_string()),
+        };
+
+        users.insert(username.clone(), user.clone());
+        Ok(user)
+    }


seriously, you have a hashmap storing key username and value username, id this does makes sense for the use case, what i mean here is there is a better way of doing this, and i have not even seen where you making use of this id

Christiantyemele · 2025-04-08T07:44:07Z

src/bin/server/user.rs

+    pub async fn login(&self, username: Arc<String>) -> anyhow::Result<User> {
+        let users = self.users.lock().await;


For now i understand password verification will be done later

Christiantyemele · 2025-04-08T07:45:05Z

src/bin/server/user.rs

+    pub async fn is_active(&self, username: &Arc<String>) -> bool {
+        let active_users = self.active_users.lock().await;
+        active_users.contains_key(username)
+    }
+}


This is not used and i can figure out where its even gonna be used, why do want to have users and active_users ?

Christiantyemele · 2025-04-08T07:51:43Z

src/bin/server/connection.rs

+    user_manager: Arc<UserManager>,
+) -> anyhow::Result<()> {
    let outbound = Arc::new(Outbound::new(socket.clone()));
+    let mut connection = Connection::new();


why are you doing this like why do want to keep track of the user in this way, mean while the user manager does that already

Christiantyemele · 2025-04-08T16:50:00Z

@chojuninengu indicate if you need help

chojuninengu added 6 commits April 3, 2025 00:24

feat(group): implement message handling for subscribers in Group

cc7cf83

Feat(user): integrate user management into server connection handling

84e3b85

Feat(user): implement UserManager for user registration, login, and a…

80a00b7

…uthentication

Feat(user): extend user functionality with registration, login, and a…

0d92490

…uthentication responses

Feat(connection): enhance connection handling with user authenticatio…

5ca1ffb

…n and session management

Implement interactive chat mode with user authentication Rust-Cameroon#1

6c7834b

chojuninengu requested review from Blindspot22, Christiantyemele, Valsuh45 and onelrian April 7, 2025 09:34

Dericko681 previously approved these changes Apr 7, 2025

View reviewed changes

Merge branch 'main' into feature/interactive-chat

509db5f

chojuninengu dismissed Dericko681’s stale review via 509db5f April 7, 2025 15:39

chojuninengu force-pushed the feature/interactive-chat branch from 509db5f to c4a9fdc Compare April 7, 2025 16:25

fix: resolve merge conflicts in client.rs

8f91f07

chojuninengu force-pushed the feature/interactive-chat branch from c4a9fdc to 8f91f07 Compare April 7, 2025 16:34

chojuninengu added 5 commits April 7, 2025 21:00

Fix formatting issues and merge conflicts Rust-Cameroon#1

9cee217

refactor: improve server connection handling and default address conf…

b1f72e3

…iguration

refactor: simplify Connection initialization and update group handlin…

68560da

…g to be asynchronous

refactor: restructure GroupTable to use named fields and enable async…

950ded6

…hronous access

Add #[allow(dead_code)] to is_active method

8e74370

chojuninengu requested a review from Dericko681 April 7, 2025 20:24

chore: update remove unnecessary entry

7bf49a3

ci: add --force flag to cargo-audit installation

a4a214c

Dericko681 reviewed Apr 7, 2025

View reviewed changes

chojuninengu requested a review from Dericko681 April 7, 2025 21:28

Christiantyemele requested changes Apr 8, 2025

View reviewed changes

Update ci.yml that runs without the "--force to install cargo-audit"

31f038a

		let join_command = FromClient::Join {
		group_name: Arc::new(group.clone()),

		pub async fn login(&self, username: Arc<String>) -> anyhow::Result<User> {
		let users = self.users.lock().await;

Conversation

chojuninengu commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dericko681 commented Apr 7, 2025

Uh oh!

chojuninengu commented Apr 7, 2025

Uh oh!

Dericko681 commented Apr 7, 2025

Uh oh!

chojuninengu commented Apr 7, 2025

Uh oh!

ndefokou commented Apr 7, 2025

Uh oh!

chojuninengu commented Apr 7, 2025

Uh oh!

sinke237 commented Apr 7, 2025

Uh oh!

chojuninengu commented Apr 7, 2025

Uh oh!

Dericko681 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Christiantyemele Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Christiantyemele commented Apr 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chojuninengu commented Apr 7, 2025 •

edited

Loading

Christiantyemele Apr 8, 2025 •

edited

Loading