feat: show duration of tracks/recordings in yim#1036
Conversation
|
I'm still pretty unhappy with the code, especially the duplicated logic in the recording and track formatters. Moreover, since this touches some core parts of alistral, I'm unsure whether my chosen way to make this optional and only active in YIM is ideal. Definitely open to suggestions here. |
|
Code wise, it's fine IMO. Would need a rebase on the new top printer but by using a builder pattern it should be fine. What I struggle with is how the duration is shown. Right now it looks like a disambiguation on the artist credit. Although I don't really have any other ideas for where to put it instead. I need to checkout the branch and try out stuff. One thing for sure is that I'd probably put it behind a cli flag as it can make the title more verbose |
|
Many good arguments. I'll give it a rebase and fix any issues, then you can have a look at it and experiment a bit. |
e3fa9a7 to
96b7481
Compare
This adds the duration of each top track/recording in the year in music report.
96b7481 to
3128b3f
Compare
This adds the duration of each top track/recording in the year in music report.
Fixes #1008.
Example