Skip to content

App External-Name Handling#286

Merged
lennardrother merged 22 commits into
mainfrom
238-task-external-name-app-ensure-adr-compliance
May 28, 2026
Merged

App External-Name Handling#286
lennardrother merged 22 commits into
mainfrom
238-task-external-name-app-ensure-adr-compliance

Conversation

@lennardrother
Copy link
Copy Markdown
Collaborator

@lennardrother lennardrother commented May 20, 2026 •
edited
Loading

Closes: #238

  1. Implemented correct external-name handling in Observe, Create and Delete functions
  2. Adapted unit tests for Observe, Create and Delete functions
  3. Created E2E import test
  4. Created upgrade test for external-name behavior
  5. Added documentation

@lennardrother lennardrother linked an issue May 20, 2026 that may be closed by this pull request
[TASK] External Name (App): Ensure ADR Compliance #238
Closed
10 tasks
@lennardrother lennardrother marked this pull request as ready for review May 26, 2026 06:12
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 26, 2026 09:39 — with GitHub Actions Inactive
@lennardrother
Observe
f448a60 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Update and delete
a67bd79 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Add CRD comment
e6e5141 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Add e2e import test and fix controller unit test
3389828 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Add upgrade test
c771e0c 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Add newline
13d7ba9 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Fix CR
d4c27b0 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Do not call Get in the same cycle external-name is set
faf626d 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Add test case for GetBySpec fails with non 404
0973323 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Improve unit tests
f4b7c50 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Create test helper function for common assertions
7a1bad8 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Remove dead mock
8e58034 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Add GUID assertion after import
0ab895d 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Update upgrade test
eb0e19f 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Extract updateObservedStatus
fcfc626 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Cleanup
960e88e 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother
Fix lint
1d02ad5 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother lennardrother force-pushed the 238-task-external-name-app-ensure-adr-compliance branch from f704721 to 1d02ad5 Compare May 28, 2026 08:43
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 28, 2026 08:43 — with GitHub Actions Inactive
@lennardrother
Return error
1ea863c 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 28, 2026 08:45 — with GitHub Actions Inactive
@lennardrother
fix test
b42d6bc 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 28, 2026 09:04 — with GitHub Actions Inactive
SatabdiG
SatabdiG reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, some minor comments from my side.

Comment thread internal/controller/app/controller.go Outdated
Comment thread internal/controller/app/controller_test.go
Comment thread test/upgrade/app_external_name_upgrade_test.go Outdated
@lennardrother
Early exit
ac461fc 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 28, 2026 12:20 — with GitHub Actions Inactive
@lennardrother
full diff ignoring CreatedAt and UpdatedAt
6f40d72 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 28, 2026 12:53 — with GitHub Actions Inactive
@lennardrother
Remove redundant UUID check
1b9c1a1 
Signed-off-by: Lennard Rother <l.rother@sap.com>
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval May 28, 2026 12:56 — with GitHub Actions Inactive
@lennardrother lennardrother requested a review from SatabdiG May 28, 2026 12:56
SatabdiG
SatabdiG approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@lennardrother lennardrother merged commit 6ae59f9 into main May 28, 2026
12 checks passed
@lennardrother lennardrother deleted the 238-task-external-name-app-ensure-adr-compliance branch May 28, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SatabdiG SatabdiG SatabdiG approved these changes

@Kukkerem Kukkerem Awaiting requested review from Kukkerem

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TASK] External Name (App): Ensure ADR Compliance

2 participants

@lennardrother @SatabdiG