[281#3] feat: wire Crossplane default labels and user metadata into all CF resources#289
Closed
mpechkurov wants to merge 1 commit into
Closed
Conversation
…sources All 7 eligible resource Create/Update functions now call BuildMetadata, ensuring default Crossplane labels (crossplane-kind, crossplane-name, crossplane-providerconfig) and user-provided labels/annotations from forProvider are included in CF API calls. Key changes: - All IsUpToDate functions now detect metadata drift (subset semantics) - Observation functions read back labels/annotations from CF - Org gets LateInitialize for metadata (with StripDefaultLabels) - Remove stale Domain/Space update guards - Add metadata.StripDefaultLabels helper - Add SetLabels/SetAnnotations fake builders for testing - Update controller tests for new metadata-aware behavior Closes #39 [281#3]
mpechkurov
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
Collaborator
|
Closing as #281 received review comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BuildMetadata, ensuring default Crossplane labels (crossplane-kind,crossplane-name,crossplane-providerconfig) and user-provided labels/annotations are included in CF API callsIsUpToDatefunctions now detect metadata drift using subset semanticsLateInitializefor metadata (withStripDefaultLabelsto avoid circular updates)SetLabels/SetAnnotationsfake builders for testingmetadata.StripDefaultLabelshelperWhy
Core delivery of #39. Every CF resource now gets
crossplane-kind,crossplane-name,crossplane-providerconfiglabels automatically and tracks user-defined metadata.Part of
Split from #281 — PR 3 of 6 (core feature). Depends on [281#1] + [281#2].
Merge order: [281#1] → [281#2] → [281#3] → [281#4] → [281#5] → [281#6]