[281#4] fix(exporter): strip Crossplane default labels from exported CF resources#290
Closed
mpechkurov wants to merge 2 commits into
Closed
[281#4] fix(exporter): strip Crossplane default labels from exported CF resources#290mpechkurov wants to merge 2 commits into
mpechkurov wants to merge 2 commits into
Conversation
…rces Add metadata.StripDefaultLabels() to remove crossplane-kind, crossplane-name, and crossplane-provider-config labels from CF resource metadata before writing exported CR manifests. These labels are infrastructure metadata computed by the controller and should not appear in ForProvider specs — a new CR gets different values and the controller recomputes them on reconcile. - New: cmd/exporter/cf/metadata/metadata.go — StripDefaultLabels helper - Updated app, org, serviceinstance, and space exporters - App exporter also gains previously missing ResourceMetadata block
- Group metadata import with other crossplane-provider-cloudfoundry imports in exporter convert files (goimports convention) - Remove json.MarshalIndent debug logging from SRB e2e test poll loop
mpechkurov
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
Collaborator
|
Closing as #281 received review comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cmd/exporter/cf/metadata/metadata.gowithStripDefaultLabelshelpercrossplane-kind,crossplane-name,crossplane-providerconfigfrom exported CR manifestsWhy
Default labels are infrastructure metadata computed by the controller from the CR identity. They are semantically incorrect for a new/exported CR (different name, different ProviderConfig) and the controller will recompute them on the next reconcile.
Part of
Split from #281 — PR 4 of 6. Depends on [281#1] only (can be merged independently of [281#2] and [281#3]).
Merge order: [281#1] → [281#2] → [281#3] → [281#4] → [281#5] → [281#6]