[281#5] refactor(route): split GetByIDOrSpec into FindRouteBySpec and GetRouteByGUID#291
Closed
mpechkurov wants to merge 1 commit into
Closed
Conversation
…eByGUID Replace the hybrid GetByIDOrSpec lookup with two dedicated methods: - FindRouteBySpec: backwards-compat lookup when external name is empty - GetRouteByGUID: direct GUID lookup (primary path) Moves late-initialization to the backwards-compat block, running before GUID validation. GetRouteByGUID returns (obs, exists, error) instead of the old nil-check convention. Also simplifies Org controller GUID validation (fails fast on invalid format instead of attempting API calls). [281#5]
mpechkurov
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
Collaborator
|
Closing as #281 received review comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GetByIDOrSpecfrom Route service interfaceFindRouteBySpec(backwards-compat when external name is empty) andGetRouteByGUID(primary path)Why
The hybrid
GetByIDOrSpecmixed two responsibilities (lookup by spec for adoption, and direct GUID fetch for normal operation). Splitting them clarifies intent and simplifies error handling.Part of
Split from #281 — PR 5 of 6 (independent refactor). Depends on [281#3].
Merge order: [281#1] → [281#2] → [281#3] → [281#4] → [281#5] → [281#6]