[281#6] test: add metadata test coverage (unit, e2e, upgrade)#292
Closed
mpechkurov wants to merge 4 commits into
Closed
[281#6] test: add metadata test coverage (unit, e2e, upgrade)#292mpechkurov wants to merge 4 commits into
mpechkurov wants to merge 4 commits into
Conversation
Add GenerateCreate, GenerateUpdate, GenerateObservation, and IsUpToDate tests for Domain, Org, and Space clients (new files). Add TestIsUpToDate_Metadata to App, Route, SCB, and ServiceInstance existing test files. Covers nil metadata, label drift/match, annotation drift/match, and subset semantics where applicable.
Add e2e test coverage for Crossplane default labels and user-provided labels/annotations on CF resources. New AssertDefaultLabels and AssertLabelsAndAnnotations helpers verify crossplane-kind, crossplane-name, and crossplane-providerconfig labels as well as user metadata. - Add label/annotation assertions to app, orgspace, services, and SRB tests - Add labels and annotations to all CR YAML manifests - Poll for updated labels after SRB update (reconciler async) - Skip label checks for observe-only resources (Org, Domain, etc.) - Fix gofmt spacing, trailing whitespace, missing newlines - Fix dangling close-paren syntax error in orgspace test - Move SRB updated manifest to updated/ subdirectory
Verify that Crossplane default labels (crossplane-kind, crossplane-name, crossplane-provider-config) are correctly applied to existing Space resources after a provider upgrade. - Pre-upgrade: assert no crossplane-* labels on CF resource - Post-upgrade: assert all 3 default labels present with correct values - Uses observe-only Org CR as Space dependency - Follows CustomUpgradeTestBuilder pattern from existing upgrade tests
Both spaces had forProvider.name 'e2e-space', causing a CF naming collision within the same org. Renamed to e2e-space-ref and e2e-space-name to match their CR metadata names.
mpechkurov
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
Collaborator
|
Closing as #281 received review comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IsUpToDate/GenerateCreate/GenerateUpdate/GenerateObservationtests for Domain, Org, Space (new files)TestIsUpToDate_Metadatato App, Route, SCB, ServiceInstance existing test filesAssertDefaultLabelsandAssertLabelsAndAnnotationshelpers verify crossplane labels + user metadataCoverage
Part of
Split from #281 — PR 6 of 6. Depends on [281#3].
Merge order: [281#1] → [281#2] → [281#3] → [281#4] → [281#5] → [281#6]