Skip to content

Migrate CF secrets to environment secrets#298

Merged
jn-av merged 1 commit into
mainfrom
feat/environment-secrets
May 29, 2026
Merged

Migrate CF secrets to environment secrets#298
jn-av merged 1 commit into
mainfrom
feat/environment-secrets

Conversation

@jn-av
Copy link
Copy Markdown
Member

@jn-av jn-av commented May 29, 2026

Adds environment: pr-e2e-no-approval to the upgrade-test job, which was the only workflow accessing CF_CREDENTIALS and CF_ENVIRONMENT without an environment gate. All other workflows (e2e_test.yaml, pr-e2e.yaml, release.yaml) already ran within a GitHub environment.

@jn-av jn-av had a problem deploying to pr-e2e-no-approval May 29, 2026 09:17 — with GitHub Actions Failure
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this

@jn-av jn-av had a problem deploying to pr-e2e-no-approval May 29, 2026 09:33 — with GitHub Actions Failure
@jn-av jn-av had a problem deploying to pr-e2e-no-approval May 29, 2026 10:41 — with GitHub Actions Failure
@jn-av jn-av had a problem deploying to pr-e2e-no-approval May 29, 2026 11:03 — with GitHub Actions Failure
@jn-av jn-av had a problem deploying to pr-e2e-no-approval May 29, 2026 12:13 — with GitHub Actions Failure
@jn-av jn-av temporarily deployed to pr-e2e-no-approval May 29, 2026 12:43 — with GitHub Actions Inactive
@jn-av jn-av merged commit 98cb8cd into main May 29, 2026
12 of 17 checks passed
@jn-av jn-av deleted the feat/environment-secrets branch May 29, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants