Skip to content

add unit test for alertSlice reducer#707

Open
Kumkum2301 wants to merge 4 commits into
SB2318:mainfrom
Kumkum2301:fix/redux-slice-unit-tests
Open

add unit test for alertSlice reducer#707
Kumkum2301 wants to merge 4 commits into
SB2318:mainfrom
Kumkum2301:fix/redux-slice-unit-tests

Conversation

@Kumkum2301
Copy link
Copy Markdown

Summary

Added unit test for alertSlice reducer initial state.

Type of Change

  • Documentation update

Work Area

  • Frontend

Testing

  • npm test

@github-actions
Copy link
Copy Markdown
Contributor

Thank you @, for creating the PR and contributing to our UltimateHealth project 💗.
Our team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Copy Markdown
Owner

@SB2318 SB2318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for taking the time to put this contribution together.

Before we can get this merged, there are two procedural things we need to address to keep our codebase maintainable:

1. Link the Issue
Could you please update the PR description to mention the specific issue this resolves? (e.g., adding Fixes #123 or Resolves #123 to the description). This automatically links the context and closes the issue when merged, which helps us track the project history.

2. Add Unit Tests for UserSlice
As a standard practice, any new Redux slices or modifications to global state management require test coverage before merging. Please add the corresponding unit tests for the UserSlice. Specifically, ensure we are testing:

  • The initial state.
  • State transitions for any newly added reducers/actions.
  • Edge cases or error states (if you are handling asynchronous thunks).

Let me know if you need any guidance on setting up the tests for the slice, otherwise ping me once you've pushed the updates and I'll gladly take another look! 🚀

@Kumkum2301 Kumkum2301 requested a review from SB2318 May 16, 2026 12:19
Copy link
Copy Markdown
Owner

@SB2318 SB2318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the changes and cover UserSlice test.

@Kumkum2301 Kumkum2301 requested a review from SB2318 May 16, 2026 12:35
@Kumkum2301
Copy link
Copy Markdown
Author

Added UserSlice tests and resolved merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants