Схема grapqhl#1
Open
Rupikz wants to merge 5 commits into
Open
Conversation
qoob23
reviewed
May 24, 2023
| updateLesson(input: UpdateLessonInput!): Lesson! | ||
| removeLesson(id: ID!): Boolean! | ||
|
|
||
| createEducationSubject(input: CreateEducationSubjectInput!): Subject! |
qoob23
reviewed
May 24, 2023
| type LessonGroupByWeekDay { | ||
| weekDay: WeekDay! | ||
| lessons: [Lesson!]! | ||
| } |
Member
There was a problem hiding this comment.
У вас же расписание зависит от WeekDay и WeekType. Кажется тут группировка сломана.
qoob23
reviewed
May 24, 2023
| timeStart: Time! | ||
| timeEnd: Time! | ||
| weekDay: WeekDay! | ||
| weekType: WeekType! |
Member
There was a problem hiding this comment.
190-191 - довольно хрупкая хуйня, если в каком-то универе расписание не будет завязано на чётные - нечётные недели
В качестве альтернативы можно сделать ScheduleType - отдельный тип, который будет описывать правила составления расписания. Первым очевидно будет стандартный механизм, основанный на чётности-нечётности недели. Но можно будет добавить и другие варианты.
Member
Author
There was a problem hiding this comment.
Можно наверное решить это новым типом недели "WeekType.REGULAR" - такие уроки будут проходить каждую неделю, независимо от чётности
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.