Skip to content

Rename Regimes to RegimeList#674

Merged
kelle merged 2 commits intoSIMPLE-AstroDB:mainfrom
ying2212:fix-regimes-name
Mar 4, 2026
Merged

Rename Regimes to RegimeList#674
kelle merged 2 commits intoSIMPLE-AstroDB:mainfrom
ying2212:fix-regimes-name

Conversation

@ying2212
Copy link
Member

@ying2212 ying2212 commented Mar 4, 2026

Short description: This PR is to fix the AttributeError in astrodb_utils's get_db_regime
looking for a table called RegimeList while our schema defined it as Regimes.

What I changed:

  • Renamed all occurrence ofRegimes to RegimeList in schema.yaml
  • Renamed data/reference/Regimes.json to RegimeList.json
  • Updated REFERENCE TABLE RegimeList in __init__.py
  • Updated Regime name in test/ files

Link to relevant issue: Closes #673

@kelle
Copy link
Collaborator

kelle commented Mar 4, 2026

Run the tests locally if you can. Multiple tests might need to modification.

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@kelle kelle merged commit d742130 into SIMPLE-AstroDB:main Mar 4, 2026
3 checks passed
@kelle kelle mentioned this pull request Mar 4, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema table Regimes incompatible with astrodb_utils RegimeList

2 participants