feat(event): add ProtectionCreateEvent for player protection actions by TheBjoRedCraft · Pull Request #17 · SLNE-Development/surf-protect

TheBjoRedCraft · 2026-03-16T16:29:34Z

No description provided.

Copilot

Pull request overview

Adds a new Bukkit event intended to signal when a player successfully creates a protection, and updates Gradle version management to be driven via gradle.properties.

Changes:

Introduce ProtectionCreateEvent (custom PlayerEvent) for protection creation.
Hook the event into the successful protection purchase/creation flow.
Move project version configuration to gradle.properties and read it from the build script.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt`	Attempts to emit `ProtectionCreateEvent` after successful protection creation.
`src/main/kotlin/dev/slne/surf/protect/paper/event/ProtectionCreateEvent.kt`	Adds the new custom Bukkit event class.
`gradle.properties`	Adds centralized `version` property (and Kotlin code style setting).
`build.gradle.kts`	Reads `version` from Gradle properties instead of hardcoding it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

src/main/kotlin/dev/slne/surf/protect/paper/event/ProtectionCreateEvent.kt

Copilot

Pull request overview

Adds a new Bukkit/Paper event to signal when a player successfully creates a protection region, and wires it into the region purchase/creation flow (with additional spawn-protection handling and build versioning updates).

Changes:

Introduce ProtectionCreateEvent and fire it after a successful protection purchase.
Add a new region creation state for spawn-protected areas and introduce checks for “too near to spawn”.
Move project versioning into gradle.properties and read it from build.gradle.kts.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`src/main/kotlin/dev/slne/surf/protect/paper/region/info/RegionCreationState.kt`	Adds `TOO_NEAR_FROM_SPAWN` state for region creation outcomes.
`src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt`	Adds spawn-distance validation, fires `ProtectionCreateEvent` on success, and runs the event call on the global dispatcher.
`src/main/kotlin/dev/slne/surf/protect/paper/event/ProtectionCreateEvent.kt`	New Bukkit event class emitted on protection creation.
`gradle.properties`	Adds `kotlin.code.style=official` and defines a shared `version` property.
`build.gradle.kts`	Uses the `version` Gradle property instead of a hardcoded string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

src/main/kotlin/dev/slne/surf/protect/paper/region/info/RegionCreationState.kt

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/kotlin/dev/slne/surf/protect/paper/region/info/RegionCreationState.kt

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

src/main/kotlin/dev/slne/surf/protect/paper/menu/dialog/ProtectionAddMemberDialog.kt

…emberDialog

…sView

…ags and ProtectionEditFlagsView

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

src/main/kotlin/dev/slne/surf/protect/paper/menu/view/flags/ProtectionEditFlagsView.kt

…er list interactions

Copilot

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T15:41:56Z

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

+            val state = flag.initialState ?: StateFlag.State.ALLOW
+
+            if (flag.isPlayerRelated) {
+                region.setFlag(flag.flag.regionGroupFlag, RegionGroup.NON_MEMBERS)
+                region.setFlag(flag.flag, state)
+
+                region.setFlag(flag.flag.regionGroupFlag, RegionGroup.MEMBERS)
+                region.setFlag(flag.flag, StateFlag.State.ALLOW)
+
+                continue
+            }
+
+            region.setFlag(flag.flag, state)
+        }


For non-player-related flags where initialState is null, applyDefaultFlags falls back to ALLOW and explicitly sets the flag. Previously those flags were left unset (null) during region creation, allowing parent/global region settings to apply. Explicitly forcing ALLOW changes behavior in setups that rely on global denies and can unintentionally override higher-level protection policies. Consider skipping setFlag when initialState is null (or only applying defaults for isPlayerRelated flags here).

Copilot · 2026-03-23T15:41:57Z

src/main/kotlin/dev/slne/surf/protect/paper/menu/view/flags/ProtectionEditFlagsView.kt

+        render.layoutSlot('P')
            .updateOnStateChange(paginationState)
-            .displayIf { _ ->
-                pagination.canBack()
-            }
-            .onRender { slotRender ->
-                if (pagination.canBack()) {
-                    slotRender.item = previousItem
-                } else {
-                    slotRender.item = outlineItem
-                }
+            .onRender {
+                if (pagination.canBack()) previousItem else outlineItem
            }


The .onRender { if (pagination.canBack()) previousItem else outlineItem } block doesn't assign the computed item to the slot (contrast with other views that do slotRender.item = ...). If onRender here is the usual (SlotRender) -> Unit, this will result in the slot not updating. Consider using the slotRender parameter and setting slotRender.item explicitly (and same for the next-page slot).

Copilot · 2026-03-23T15:41:57Z

src/main/kotlin/dev/slne/surf/protect/paper/menu/view/flags/ProtectionEditFlagsView.kt

+    private fun applyState(
+        region: ProtectedRegion,
+        flag: EditableProtectionFlags,
+        state: StateFlag.State
+    ) {
+        if (flag.isPlayerRelated) {
+            region.setFlag(flag.flag, StateFlag.State.ALLOW)
+            if (state == StateFlag.State.ALLOW) {
+                region.setFlag(flag.flag.regionGroupFlag, null)
+            } else {
+                region.setFlag(flag.flag.regionGroupFlag, RegionGroup.MEMBERS)
+            }
+        } else {
+            region.setFlag(flag.flag, state)
+        }


applyState for player-related flags sets the flag value to ALLOW and only toggles regionGroupFlag between null and MEMBERS. With WorldGuard's group flag semantics, setting group=MEMBERS + ALLOW does not deny non-members (it just makes the flag not apply to them, so they can still be allowed by defaults/parents). To enforce “members-only”, set StateFlag=DENY with regionGroupFlag=NON_MEMBERS; to allow everyone, set StateFlag=ALLOW with regionGroupFlag=null/ALL (or clear both).

Copilot · 2026-03-23T15:41:57Z

src/main/kotlin/dev/slne/surf/protect/paper/menu/dialog/ProtectionAddMemberDialog.kt

+    if (playerName.isEmpty() || playerName.isBlank() || playerName.length > 16) {
+        player.sendText {
+            appendErrorPrefix()
+            error("Der Spielername ist ungültig.")
+        }
+        player.closeDialog()
+        viewFrame.open(
+            ProtectionMemberListView::class.java,
+            player,
+            mapOf("protection" to protection)
+        )
+        return
+    }


With the new invalid-name validation, closing the dialog (which currently triggers onClose -> handleAdd(...)) will now show an error (“Spielername ist ungültig.”) and reopen the member list even if the user simply cancelled. Consider changing onClose to behave like a cancel action (navigate back without attempting to add), and keep handleAdd only for onSearch.

Copilot · 2026-03-23T15:41:58Z

...in/kotlin/dev/slne/surf/protect/paper/menu/view/members/ProtectionMemberRemoveConfirmView.kt

+    private fun createMemberItem(member: OfflinePlayer) = buildItem(Material.PLAYER_HEAD) {
        displayName {
-            protectColored(member.displayName.toSmallCaps(), TextDecoration.BOLD)
+            protectColored(member.name?.toSmallCaps() ?: "#Unknown", TextDecoration.BOLD)


The fallback name "#Unknown" is English while the rest of the UI/messages in this view are German (and elsewhere you use #Unbekannt). Consider using a consistent localized fallback string here as well.

Suggested change

protectColored(member.name?.toSmallCaps() ?: "#Unknown", TextDecoration.BOLD)

protectColored(member.name?.toSmallCaps() ?: "#Unbekannt", TextDecoration.BOLD)

Copilot · 2026-03-23T15:41:58Z

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

+                withContext(plugin.globalRegionDispatcher) {
+                    protectionUser.bukkitPlayer?.let {
+                        ProtectionCreateEvent(it).callEvent()
+                    }
                }


ProtectionCreateEvent is a PlayerEvent, so it should be fired from the correct Folia thread context for that player. globalRegionDispatcher doesn't guarantee entity-thread safety for player-bound operations; prefer plugin.entityDispatcher(player) (or another player/region-appropriate dispatcher) when calling Bukkit/Paper APIs like event dispatch.

Copilot · 2026-03-23T15:41:58Z

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt

+                region.setFlag(flag.flag.regionGroupFlag, RegionGroup.MEMBERS)
+                region.setFlag(flag.flag, StateFlag.State.ALLOW)
+


applyDefaultFlags currently sets the RegionGroup flag twice for player-related flags (NON_MEMBERS and then MEMBERS), and also overwrites the StateFlag value (state then ALLOW). The second assignment wins, so the final configuration is effectively group=MEMBERS and state=ALLOW, which does not enforce “deny non-members / allow members” as intended. Suggestion: for player-related flags, set regionGroupFlag = NON_MEMBERS and keep the flag state as DENY (or whatever initialState is), without later overwriting it; this makes the deny apply only to non-members while members are unaffected.

Suggested change

region.setFlag(flag.flag.regionGroupFlag, RegionGroup.MEMBERS)

region.setFlag(flag.flag, StateFlag.State.ALLOW)

Copilot · 2026-03-23T15:41:59Z

src/main/kotlin/dev/slne/surf/protect/paper/menu/view/flags/ProtectionEditFlagsView.kt

+    private fun getCurrentState(
+        region: ProtectedRegion,
+        flag: EditableProtectionFlags
+    ): StateFlag.State {
+        return if (flag.isPlayerRelated) {
+            val group = region.getFlag(flag.flag.regionGroupFlag)
+            if (group == RegionGroup.MEMBERS) StateFlag.State.DENY else StateFlag.State.ALLOW
+        } else {
+            region.getFlag(flag.flag) ?: flag.initialState ?: StateFlag.State.ALLOW
+        }


getCurrentState for isPlayerRelated flags is derived from regionGroupFlag == MEMBERS, but (a) the default setup in applyDefaultFlags uses NON_MEMBERS for the “members-only” intent, and (b) the actual StateFlag value is ignored. This will make the UI show the wrong state and toggle from an incorrect baseline. Consider mapping the UI state from the combination of StateFlag value + regionGroupFlag (e.g. DENY + NON_MEMBERS => “Nur für Mitglieder”, otherwise => “Für alle erlaubt”).

Copilot · 2026-03-23T15:41:59Z

src/main/kotlin/dev/slne/surf/protect/paper/menu/dialog/ProtectionRenameDialog.kt

+        viewFrame.open(
+            ProtectionInfoView::class.java,
+            player,
+            mapOf("protection" to protection)
+        )


On validation failures you open ProtectionInfoView, but the dialog isn't closed in these early-return branches. This can leave the search dialog still open (or re-openable) on top of the inventory UI. Consider calling player.closeDialog() before opening the view (same applies to the other early-return validations in this function).

feat(event): add ProtectionCreateEvent for player protection actions

07ea2c9

TheBjoRedCraft self-assigned this Mar 16, 2026

Copilot AI review requested due to automatic review settings March 16, 2026 16:29

Copilot started reviewing on behalf of TheBjoRedCraft March 16, 2026 16:30 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

src/main/kotlin/dev/slne/surf/protect/paper/region/ProtectionRegion.kt Outdated Show resolved Hide resolved

src/main/kotlin/dev/slne/surf/protect/paper/event/ProtectionCreateEvent.kt Show resolved Hide resolved

JoField08 previously approved these changes Mar 16, 2026

View reviewed changes

feat(event): call ProtectionCreateEvent for player protection actions

ec2810e

TheBjoRedCraft dismissed JoField08’s stale review via ec2810e March 16, 2026 18:07

feat(event): add spawn proximity check for region creation

d534c87

Copilot AI review requested due to automatic review settings March 21, 2026 13:25

Copilot started reviewing on behalf of TheBjoRedCraft March 21, 2026 13:26 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

TheBjoRedCraft and others added 3 commits March 21, 2026 22:56

Merge branch 'version/1.21.11' into feat/add-event

b77d834

feat(event): validate player name format in protection member addition

fe4eff7

Merge remote-tracking branch 'origin/feat/add-event' into feat/add-event

826a6e8

Copilot AI review requested due to automatic review settings March 21, 2026 22:02

Copilot started reviewing on behalf of TheBjoRedCraft March 21, 2026 22:03 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

TheBjoRedCraft added 3 commits March 21, 2026 23:59

feat(event): add early return for player validation in ProtectionAddM…

9074d0e

…emberDialog

feat(event): enhance chest access flag handling in ProtectionEditFlag…

9e972c6

…sView

feat(event): add player-related flag handling in EditableProtectionFl…

3ccd419

…ags and ProtectionEditFlagsView

Copilot AI review requested due to automatic review settings March 22, 2026 09:48

Copilot started reviewing on behalf of TheBjoRedCraft March 22, 2026 09:48 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

TheBjoRedCraft added 2 commits March 23, 2026 13:41

feat(event): set default states for protection flags and enhance memb…

80bda29

…er list interactions

feat(event): improve protection renaming flow and handle cancellation

b1f56c7

Copilot AI review requested due to automatic review settings March 23, 2026 15:34

Copilot started reviewing on behalf of TheBjoRedCraft March 23, 2026 15:35 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

	protectColored(member.name?.toSmallCaps() ?: "#Unknown", TextDecoration.BOLD)
	protectColored(member.name?.toSmallCaps() ?: "#Unbekannt", TextDecoration.BOLD)

		region.setFlag(flag.flag.regionGroupFlag, RegionGroup.MEMBERS)
		region.setFlag(flag.flag, StateFlag.State.ALLOW)

Conversation

TheBjoRedCraft commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants