Open
Conversation
Since gen_evts() is executed in separate processes for parallelisation, this needed to be done in that function, which required changes to the surrounding code.
* update hash of sample output file * remove old sample output file from tests directory * remove diff from CI (was left over from initial debugging) and set explicit exit code instead
Member
Author
|
Hmm … the integration test is failing under Ubuntu; the only difference I can see from the logs is in the
Not sure what's going on there; I'll look into it (but am on annual leave this afternoon, so this will need to wait until next week). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52. As a side effect (because the allowed eNu range for certain channels is now slightly larger), the event rate in
esandc12e/c12ebchannels increases by a few per cent for LS detectors.(Not 100% happy with how I implemented this, but I think that’s about as good as it gets without a larger restructuring of the code base. At least I got to clean up the
main()implementation slightly.)