feat: add Stellar Expert explorer links to transaction toasts and fix…#173
Open
darius-daniel wants to merge 2 commits into
Open
feat: add Stellar Expert explorer links to transaction toasts and fix…#173darius-daniel wants to merge 2 commits into
darius-daniel wants to merge 2 commits into
Conversation
|
@darius-daniel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Stellar Expert explorer links to transaction toasts
Related Issues: Fixes #146, #110
Description
This PR implements automatic Stellar Expert explorer links for all transaction success toasts across the application. It also includes critical fixes for environment variable loading in the monorepo and addresses several TypeScript/Linter issues in the trade feature.
Changes
1. Transaction Explorer Links
.tsand updated thesubmitTxutility to inject a "View transaction →" link into every success toast.NETWORK.explorerBaseUrl(supporting both Testnet and Mainnet) and open in a new tab.window.opentriggers as the link is now integrated into the toast UI.2. Environment Configuration
Missing env var: VITE_NETWORKerror by allowing the app to detect the active network from the root.envand then load the correspondingapps/web/.env.{network}file.3. DX & Type Safety
Property 'trade' does not existlinter errors.marketAddresswas missing from the query key.Verification Results
bun run devandbun run typecheckpass successfully.Closes #146