feat: implement unlink connected bank account API#499
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@AdityaK9822 is attempting to deploy a commit to the vestroll's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@AdityaK9822 PR should point to dev branch not main branch |
Contributor
Author
|
Here, I have changed the base into dev branch |
codeZe-us
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #488
Description
This PR implements the API endpoint to safely unlink a connected fiat bank account from an
employee's profile within an organization.
Instead of a hard deletion, this implementation uses a "soft-delete" approach by tracking when
a bank account was unlinked, ensuring that historical transaction references and audit trails
are preserved.
Changes
bankAccountDeletedAttimestamp to theemployeestable insrc/server/db/schema.ts.unlinkBankAccountinBankAccountServiceto mark accounts as unlinked.getEmployeeAccountto filter out accounts that have been unlinked.DELETEendpoint at/api/v1/finance/accounts/[id]that verifies theauthenticated user's organization ownership before unlinking the account.
Verification
DELETErequests for employees outside the user's organization are rejectedwith a 403.
fiatTransactionstable.