Skip to content

Add deploy changed/new flags#78

Open
gibson9583 wants to merge 3 commits intoSagaHealthcareIT:masterfrom
gibson9583:feature/deploy-changed
Open

Add deploy changed/new flags#78
gibson9583 wants to merge 3 commits intoSagaHealthcareIT:masterfrom
gibson9583:feature/deploy-changed

Conversation

@gibson9583
Copy link
Copy Markdown

Adds new flags to allow users to only deploy changed using DashboardStatus content. Adds another flag to optionally deploy any new/undeployed channel within the repository as well.

Closes #77

Signed-off-by: gibson9583 <cgibson@outlook.com>
Comment thread src/mirthsync/apis.clj Outdated
@jessesaga
Copy link
Copy Markdown
Contributor

Thanks for the PR, looks great!

The only thing I'd recommend is that the find-changed-channel-ids in the test file duplicates the selection logic from deploy-changed-channels rather than testing the actual function.

I think this would be good to merge once the test case tests the actual function. You could use with-redefs on mhttp/get-xml and mhttp/post-xml to verify both the code-templates-pushed true and false paths, since that conditional isn't covered right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Leverage Revision Indicator As Deploy Flag

3 participants