feat: add System Requirements page and navbar link#136
Conversation
|
@the-rahul-07 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR adds a System Requirements landing page with animated spec cards, integrating it into the app's navigation via navbar, footer, and sidebar links. The HeroSection gains a secondary entry point ("View Detailed Specs" button) to the new page. Total changes: +311 lines, -61 lines. ChangesSystem Requirements Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
landing/src/components/pages/SystemRequirements.jsx (1)
197-204: ⚡ Quick winDownload CTA bypasses the configured download URL and analytics.
Elsewhere the app downloads via the
downloadUrlenv value (VITE_DOWNLOAD_URL, falling back to the versioned installer) and firestrackDownloadClick(...). This page instead hardcodesreleases/latestand skips tracking, so the download source and analytics diverge from the navbar/hero. Consider passingdownloadUrl(and anonDownloadClickhandler) intoSystemRequirementsfor consistency.♻️ Proposed change to accept and use the shared download props
-export default function SystemRequirements({ setCurrentPage }) { +export default function SystemRequirements({ setCurrentPage, downloadUrl, isHostedInstaller, onDownloadClick }) {<a - href="https://github.com/SamXop123/Paraline/releases/latest" - target="_blank" - rel="noopener noreferrer" + href={downloadUrl} + download={isHostedInstaller ? undefined : "Paraline-Setup.exe"} + onClick={onDownloadClick} className="rounded-full bg-white px-6 py-3 text-sm font-semibold text-slate-950 transition hover:scale-[1.02] hover:bg-cyan-100" > Download for Windows </a>Then in
App.jsxpass the props through:- <SystemRequirements setCurrentPage={setCurrentPage} /> + <SystemRequirements + setCurrentPage={setCurrentPage} + downloadUrl={downloadUrl} + isHostedInstaller={isHostedInstaller} + onDownloadClick={() => trackDownloadClick("system-requirements")} + />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@landing/src/components/pages/SystemRequirements.jsx` around lines 197 - 204, The Download CTA in SystemRequirements.jsx bypasses the shared download URL and analytics; update the SystemRequirements component to accept props downloadUrl and onDownloadClick (or similar names) and use downloadUrl as the anchor href instead of the hardcoded releases/latest, and call onDownloadClick in the anchor's onClick to invoke trackDownloadClick; also update the parent (App.jsx) to pass the existing VITE_DOWNLOAD_URL-derived value and the trackDownloadClick handler into <SystemRequirements /> so downloads and analytics remain consistent across the app.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@landing/src/components/Sidebar.jsx`:
- Around line 65-70: The SidebarItem at lines showing the System Requirements
entry references an icon "./sidebar-icons/monitor.svg" that doesn't exist; fix
this by either adding the missing SVG file named monitor.svg into the
landing/public/sidebar-icons/ directory or update the Sidebar.jsx reference to
the correct existing asset path. Locate the SidebarItem usage (props: icon,
label, active, onClick) where currentPage === "system-requirements" and ensure
the icon prop points to a valid file so the image loads correctly when
setCurrentPage("system-requirements") and toggleSidebar() are called.
---
Nitpick comments:
In `@landing/src/components/pages/SystemRequirements.jsx`:
- Around line 197-204: The Download CTA in SystemRequirements.jsx bypasses the
shared download URL and analytics; update the SystemRequirements component to
accept props downloadUrl and onDownloadClick (or similar names) and use
downloadUrl as the anchor href instead of the hardcoded releases/latest, and
call onDownloadClick in the anchor's onClick to invoke trackDownloadClick; also
update the parent (App.jsx) to pass the existing VITE_DOWNLOAD_URL-derived value
and the trackDownloadClick handler into <SystemRequirements /> so downloads and
analytics remain consistent across the app.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0637218d-5467-46ba-8f75-3dbb674849c5
📒 Files selected for processing (5)
landing/src/App.jsxlanding/src/components/Footer.jsxlanding/src/components/Sidebar.jsxlanding/src/components/pages/SystemRequirements.jsxlanding/src/components/sections/HeroSection.jsx
SamXop123
left a comment
SamXop123
left a comment
There was a problem hiding this comment.
Great work. Thank you for the contribution!
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SamXop123
added
gssoc26
|
🎉 Congratulations @the-rahul-07! 🎉 Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌 🚀 What's Next?
💬 Stay Connected: Thank you again, and keep up the amazing work! 💻✨ |
2 participants
Summary
Closes #103
Added a System Requirements page so users can check if their machine supports Paraline before downloading.
Changes Made
New File
landing/src/components/pages/SystemRequirements.jsx— dedicated page with glassmorphic midnight-blue cards matching the existing site designModified Files
landing/src/App.jsx— added import, route, and navbar header linklanding/src/components/Sidebar.jsx— added System Requirements nav item under Menu sectionlanding/src/components/Footer.jsx— added System Requirements footer linklanding/src/components/sections/HeroSection.jsx— added subtle subtext below download button: "Requires Windows 10/11 (64-bit) • ~500 MB space. View Detailed Specs"Specs Covered
Summary by CodeRabbit
Release Notes