fix: don't let input events reset window controls bar hidetimeout#524
Open
fix: don't let input events reset window controls bar hidetimeout#524
Conversation
Contributor
Contributor
|
It fixes #523 (comment) but it still doesn't work when dragging seekbar handle. |
Owner
Author
I think that's caused by mp.observe_property("seeking", "native", function(_, seeking)
if user_opts.osc_on_seek then
reset_timeout()
end
end)I'll test soon, will be back home in an hour or so. |
Owner
Author
|
If you can test, try replacing it with: mp.observe_property("seeking", "native", function(_, seeking)
if user_opts.osc_on_seek then
state.showtime = mp.get_time()
end
end) |
Contributor
|
Pretty sure it was not affected by osc_on_seek when I last tested it, but you'll have to confirm. |
For example: seekbar drag shouldn't affect top bar's hide
Owner
Author
|
Done. 1f9a52c |
Contributor
|
Thanks, will check |
Owner
Author
|
Take your time, there is no rush at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #523 (comment) reported by @Keith94, ModernZ's local detective.
Changes:
hidetimeoutshould reset only if mouse is hovering it.hidetimeouton the OSC withreset_timeout().