Skip to content

fix: don't let input events reset window controls bar hidetimeout#524

Open
Samillion wants to merge 2 commits intomainfrom
fix_press_event_hidetimeout
Open

fix: don't let input events reset window controls bar hidetimeout#524
Samillion wants to merge 2 commits intomainfrom
fix_press_event_hidetimeout

Conversation

@Samillion
Copy link
Owner

@Samillion Samillion commented Mar 11, 2026

Fixes: #523 (comment) reported by @Keith94, ModernZ's local detective.

Changes:

  • Top bar (WC bar) hidetimeout should reset only if mouse is hovering it.
    • It shouldn't be affected by input events that reset hidetimeout on the OSC with reset_timeout().
  • Area elements should only affect the specific area. (ie: seek drag should not reset timeout for top bar)

@Keith94
Copy link
Contributor

Keith94 commented Mar 11, 2026

Fixes: #523 (comment) reported by @Keith94, ModernZ's local detective.

If that's true then you must be the dang genius for fixing everything lol.

I'll check it out tomorrow but I assume it works perfectly.

@Keith94
Copy link
Contributor

Keith94 commented Mar 11, 2026

It fixes #523 (comment) but it still doesn't work when dragging seekbar handle.

@Samillion
Copy link
Owner Author

It fixes #523 (comment) but it still doesn't work when dragging seekbar handle.

I think that's caused by

mp.observe_property("seeking", "native", function(_, seeking)
    if user_opts.osc_on_seek then
        reset_timeout()
    end
end)

I'll test soon, will be back home in an hour or so.

@Samillion
Copy link
Owner Author

If you can test, try replacing it with:

mp.observe_property("seeking", "native", function(_, seeking)
    if user_opts.osc_on_seek then
        state.showtime = mp.get_time()
    end
end)

@Keith94
Copy link
Contributor

Keith94 commented Mar 11, 2026

Pretty sure it was not affected by osc_on_seek when I last tested it, but you'll have to confirm.

For example: seekbar drag shouldn't affect top bar's hide
@Samillion
Copy link
Owner Author

Done. 1f9a52c

@Keith94
Copy link
Contributor

Keith94 commented Mar 11, 2026

Thanks, will check

@Samillion
Copy link
Owner Author

Take your time, there is no rush at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants