fix: prevent integer overflow in memory size calculation for tensors#16481
Merged
Conversation
This commit addresses potential integer overflow issues in memory size calculations by: - Changing num_elements type from int32_t to int64_t - Adding overflow checks before size calculations - Using large_num_elements() instead of num_elements() - Casting final size to size_t after overflow validation The changes affect BuddyMemoryManager and several kernel implementations (ExpandDims, If, Reshape, TransposeConv) to ensure safe memory operations with large tensors. ONE-DCO-1.0-Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
Collaborator
|
Got format error. |
Collaborator
|
@chunseoklee Build error T_T |
Contributor
Author
it is very strange since it succeed on my local. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses potential integer overflow issues in memory size calculations by:
The changes affect BuddyMemoryManager and several kernel implementations (ExpandDims, If, Reshape, TransposeConv) to ensure safe memory operations with large tensors.
ONE-DCO-1.0-Signed-off-by: Chunseok Lee chunseok.lee@samsung.com