Skip to content

[onert] Fix exception throw in memory manager#16482

Merged
mhs4670go merged 1 commit into
Samsung:masterfrom
arkq:throw-patch-1
Apr 21, 2026
Merged

[onert] Fix exception throw in memory manager#16482
mhs4670go merged 1 commit into
Samsung:masterfrom
arkq:throw-patch-1

Conversation

@arkq
Copy link
Copy Markdown
Contributor

@arkq arkq commented Apr 20, 2026

This commit fixes a typo causing the exception not being thrown.

Copilot AI review requested due to automatic review settings April 20, 2026 07:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a bug in the GPU CL backend memory manager where an exception object was constructed but not actually thrown, preventing failures from being surfaced during tensor creation.

Changes:

  • Throw std::runtime_error when CreateTensor(...) fails in MemoryManager::allocate().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runtime/contrib/gpu_cl/MemoryManager.h
This commit fixes a typo causing the exception not being thrown.

ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
Copy link
Copy Markdown
Collaborator

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit 378df43 into Samsung:master Apr 21, 2026
2 checks passed
@arkq arkq deleted the throw-patch-1 branch April 21, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants