[circle-mlir] Build without installing test dependencies#16485
Draft
arkq wants to merge 1 commit into
Draft
Conversation
This commit wraps GoogleTest installation with ENABLE_TEST which adds possibility to build onnx2circle without test dependencies. ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
There was a problem hiding this comment.
Pull request overview
This PR makes the circle-mlir build configurable so onnx2circle (and other non-test targets) can be built without pulling in test-only dependencies (notably GoogleTest).
Changes:
- Gate GoogleTest/CTest setup behind
ENABLE_TESTin the top-levelcircle-mlir/CMakeLists.txt. - Gate the
tools-testsubdirectory behindENABLE_TESTincircle-mlir/circle-mlir/CMakeLists.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| circle-mlir/CMakeLists.txt | Wraps CTest + GoogleTest setup in if(ENABLE_TEST) so non-test builds don’t fetch/install test deps. |
| circle-mlir/circle-mlir/CMakeLists.txt | Prevents tools-test from being configured/built when tests are disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit wraps GoogleTest installation with
ENABLE_TESTwhich adds possibility to buildonnx2circlewithout test dependencies.Testing
Verified that build with
-DENABLE_TEST=OFF -DENABLE_COVERAGE=OFFworks as expected.