[examples] Refactor examples#717
Conversation
|
I'll remove datasets and lm_eval dependencies. On second thought, it's too heavy for unittest. |
but |
|
The change is indeed large. I guess, it implements all of the improvements suggested in the issue #716. I can see that the improvements there are broken into several items (1-4). Could this PR be split into multiple PRs accordingly? (just out of curiosity 😄 ) |
Ah, no. It was only about unittest. |
Sure. I"ll split the PR into a few several PRs soon. But, it would be good to elaborate a little bit what are broken before posting another PRs. |
9946dd1 to
ffb3026
Compare
This commit adds more pipelines. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
|
@Torrero @stamalakhov PTAL. I've posted remain parts. I'll update some codes according to recent updates in exising examples. |
| # Build the algorithm config from payload. | ||
| # config = AWQConfig(**payload) | ||
| config = AWQConfig(**payload) | ||
|
|
This commit refactors examples.
The changes are really big. Therefore, please run a few simple command-level test first before approving the PR, and improve it incrementally as we use it. Or, you can just review the README files.
Related: #716
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com