Skip to content

[examples] Refactor examples#717

Merged
mhs4670go merged 1 commit into
Samsung:mainfrom
mhs4670go:ref
May 21, 2026
Merged

[examples] Refactor examples#717
mhs4670go merged 1 commit into
Samsung:mainfrom
mhs4670go:ref

Conversation

@mhs4670go
Copy link
Copy Markdown
Contributor

This commit refactors examples.

The changes are really big. Therefore, please run a few simple command-level test first before approving the PR, and improve it incrementally as we use it. Or, you can just review the README files.

Related: #716
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com

@mhs4670go
Copy link
Copy Markdown
Contributor Author

I'll remove datasets and lm_eval dependencies. On second thought, it's too heavy for unittest.

@Torrero
Copy link
Copy Markdown
Contributor

Torrero commented May 19, 2026

I'll remove datasets and lm_eval dependencies. On second thought, it's too heavy for unittest.

but lm_eval is used for evaluation of some benchmarks (piqa, truthfulqa e.t.c.), should it be reimplemeted without lm_eval?

@dvsav
Copy link
Copy Markdown
Contributor

dvsav commented May 19, 2026

The change is indeed large. I guess, it implements all of the improvements suggested in the issue #716. I can see that the improvements there are broken into several items (1-4). Could this PR be split into multiple PRs accordingly? (just out of curiosity 😄 )

@mhs4670go
Copy link
Copy Markdown
Contributor Author

mhs4670go commented May 19, 2026

@Torrero

I'll remove datasets and lm_eval dependencies. On second thought, it's too heavy for unittest.

but lm_eval is used for evaluation of some benchmarks (piqa, truthfulqa e.t.c.), should it be reimplemeted without lm_eval?

Ah, no. It was only about unittest.

@mhs4670go
Copy link
Copy Markdown
Contributor Author

mhs4670go commented May 19, 2026

@dvsav

Could this PR be split into multiple PRs accordingly? (just out of curiosity 😄 )

Sure. I"ll split the PR into a few several PRs soon. But, it would be good to elaborate a little bit what are broken before posting another PRs.

@mhs4670go mhs4670go marked this pull request as draft May 20, 2026 04:22
@mhs4670go mhs4670go force-pushed the ref branch 2 times, most recently from 9946dd1 to ffb3026 Compare May 21, 2026 05:25
@mhs4670go mhs4670go marked this pull request as ready for review May 21, 2026 05:25
This commit adds more pipelines.

TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
@mhs4670go mhs4670go removed the request for review from dvsav May 21, 2026 05:50
@mhs4670go
Copy link
Copy Markdown
Contributor Author

@Torrero @stamalakhov PTAL. I've posted remain parts. I'll update some codes according to recent updates in exising examples.

# Build the algorithm config from payload.
# config = AWQConfig(**payload)
config = AWQConfig(**payload)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@stamalakhov stamalakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Copy Markdown
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mhs4670go mhs4670go merged commit 806fb41 into Samsung:main May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants