Skip to content

[quantization] Add tied embedding bit-width validation#720

Merged
mhs4670go merged 1 commit into
Samsung:mainfrom
mhs4670go:sh
May 21, 2026
Merged

[quantization] Add tied embedding bit-width validation#720
mhs4670go merged 1 commit into
Samsung:mainfrom
mhs4670go:sh

Conversation

@mhs4670go
Copy link
Copy Markdown
Contributor

This commit adds tied embedding bit-width validation.

Related: #695 (comment)
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com

This commit adds tied embedding bit-width validation.

TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
@mhs4670go mhs4670go requested review from a team and stamalakhov May 21, 2026 01:08
print_config(args, device)

model, tokenizer = load_model_and_tokenizer(args, dtype)
validate_tied_embedding_weight_bits(model, args)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@stamalakhov stamalakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mhs4670go mhs4670go merged commit 3f667e0 into Samsung:main May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants