Use #if defined(_WIN32) instead of #if _WIN32 in public/coacd.h#101
Merged
Conversation
The bare `#if _WIN32` form trips clang's `-Wundef` on non-Windows platforms when consumers build with `-Wundef -Werror`. Unreal Engine's bundled clang on Linux is one such consumer; the warning becomes a fatal error during plugin compile. `#if defined(_WIN32)` is semantically identical (only matters when _WIN32 is defined) and silences the warning.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare
#if _WIN32on line 10 ofpublic/coacd.htrips clang's-Wundef("_WIN32" is not defined, evaluates to 0) on non-Windows platforms when consumers build with-Wundef -Werror.Concrete case where this surfaces: Unreal Engine 5.7's bundled clang on Linux turns the warning into a fatal error during plugin compile. We hit this while adding Linux support to a UE plugin that consumes CoACD (URLab-Sim/UnrealRoboticsLab#46). For now we patch the header via a build-time overlay; happy to drop that overlay once this lands.
#if defined(_WIN32)is semantically identical to#if _WIN32(the value of_WIN32only matters when it's defined, in which case it's1) and silences the warning. No behaviour change.One-line patch.