Fix RecoverParts transform order in public API#99
Merged
SarahWeiii merged 1 commit intoMay 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the inverse transform order in
public/coacd.cpp.The public
CoACD(...)path applies transforms in this order:Normalize()PCA()(optional)Compute()So recovery must happen in reverse order:
RevertPCA(rot)Recover(bbox)Before this change,
public/coacd.cpp::RecoverParts(...)called:That rotates the translation restored by
Recover(), which can offset the final convex hulls relative to the original mesh when PCA is enabled.This patch makes the public wrapper consistent with the existing internal implementation in
src/model_obj.cpp, which already applies:Change scope is intentionally minimal: one line moved, no behavior changes outside the PCA recovery path.