Open
Conversation
fadf03b to
ff35fda
Compare
Contributor
Author
|
@boydm as per our convo, we want to update this to use a streaming bitmap instead of the type I added. |
Collaborator
|
I think the returned result should be of type Scenic.Assets.Stream.Bitmap.t() We don't need to define a new type here, when the existing stream-able bitmap format already has all the same fields. Additionally, if it is a Bitmap.t(), then it can be passed directly into the streaming bitmap functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an optional
take_screenshotcallback to theScenic.Drivercallback list.This would be a way forward for screenshots that would allow pulling framebuffers from both a local driver (say, OpenGL-backed) or a web driver (say, HTML5 canvas). If a driver doesn't support a screenshot for whatever reason, this should still return a useful value of
{:ok, :not_supported, driver}.Motivation and Context
We currently don't have an easy way of grabbing the framebuffer from a driver.
This starts putting into place an interface that drivers can implement that does so.
The next step, if this is the direction we want to go, is getting this merged and updating
scenic_driver_localand other drivers to support this.Types of changes
not work as expected)
but make things better)
Checklist