π¨ Fix develop-sources include path (anchor at GITHUB_WORKSPACE) β unbreaks monorepo sublibrary CI#99
Merged
ChrisRackauckas merged 1 commit intoJun 17, 2026
Conversation
β¦s monorepo sublibrary CI) The "Develop in-repo [sources]" step (added in SciML#98) runs with `shell: julia {0}`, which writes the body to a temp file under RUNNER_TEMP and executes it from there. Julia's `include` resolves a RELATIVE path against the including file's directory (RUNNER_TEMP), not GITHUB_WORKSPACE where `.sciml-dotgithub` is checked out -- so the relative `include(joinpath(".sciml-dotgithub", ...))` failed with `SystemError: opening file ".../_temp/.sciml-dotgithub/scripts/develop_sources.jl"`. This broke every monorepo's sublibrary CI (project != '.'/'@.') the moment v1.15.1 was retagged (e.g. ModelingToolkit Sublibrary CI). Anchor the include at ENV["GITHUB_WORKSPACE"] so it resolves regardless of the temp script's location. Verified by simulating the step (julia temp-script in RUNNER_TEMP, run from a third cwd, .sciml-dotgithub under GITHUB_WORKSPACE): the relative form reproduces the SystemError; the GITHUB_WORKSPACE-anchored form loads develop_sources cleanly. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π¨ Urgent β fixes a regression that broke all monorepo sublibrary CI
The
develop_sourcesextraction in #98 (released in v1.15.1) introduced a step that fails for every monorepo, e.g. ModelingToolkit Sublibrary CI:Root cause
The "Develop in-repo
[sources]" step usesshell: julia --color=yes {0}. GitHub writes the step body to a temp file underRUNNER_TEMPand runs it from there. Julia'sincluderesolves a relative path against the including file's directory (RUNNER_TEMP), notGITHUB_WORKSPACEβ whereactions/checkoutplaced.sciml-dotgithub. Soinclude(joinpath(".sciml-dotgithub", β¦))looked inRUNNER_TEMP/.sciml-dotgithuband missed.Only monorepo sublibrary jobs hit it β the step is gated on
inputs.project != '.' && '@.', so plain-repo CI (which skips the develop step) was unaffected. That's why it surfaced as broken Sublibrary CI across MTK/Optimization/etc. right after the v1.15.1 retag.Fix
Anchor the include at
ENV["GITHUB_WORKSPACE"]:Verification
Simulated the exact step (a Julia temp-script in
RUNNER_TEMP, run from a third cwd, with.sciml-dotgithubunderGITHUB_WORKSPACE):SystemErrorverbatim;GITHUB_WORKSPACE-anchored form loadsdevelop_sourcescleanly (isdefined β true).tests.ymlpassesyaml.safe_load. (The #98 unit test exerciseddevelop_sources.jlas a function, not the workflow'sinclude, which is why this slipped through.)v1retagConsumers pin
@v1, so this only takes effect after merge and av1retag. Until then, all monorepo sublibrary CI stays broken β please fast-track.π€ Generated with Claude Code
Please review ASAP β @ChrisRackauckas.