Use SciMLTesting v1.2 (folder-based run_tests)#159
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert test/runtests.jl to the SciMLTesting run_tests dispatcher. Core test files are made self-contained by extracting the shared helper definitions (every_ad, RuleConfig types, fake detectors) into test/shared/test_setup.jl, which each Core file includes. The QA group runs in its test/qa sub-env. The public.jl version guard (VERSION >= v"1.11.0-DEV.469") is preserved via the explicit-args core thunk, since folder-discovery cannot express a per-file version guard and public.jl must not run on the LTS (1.10) matrix entry. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
3ba933b to
edab4cf
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2run_testsdispatcher (folder model).runtests.jl(every_ad,every_ad_with_options, theRuleConfigsubtypes,CustomTag, the fake sparsity/coloring detectors, and theusinglines) are extracted totest/shared/test_setup.jl, which each Core fileincludes.test/shared/is the sanctioned non-group bucket, so it is never auto-discovered as a test.test/qa/sub-env.public.jlversion guard (VERSION >= v"1.11.0-DEV.469") is preserved via an explicit-argscorethunk. Folder-discovery cannot express a per-file version guard, andpublic.jlmust NOT run on the LTS (1.10) matrix entry (names(ADTypes)does not returnpublicsymbols before 1.11, so the assertion would fail).using ADTypesis kept at top level (Main) because the printing tests qualify type modules viaBase.active_module().SciMLTestingandSafeTestsetsto the root[extras]/[targets].test/[compat]and totest/qa/Project.toml; droppedPkgfrom the root test deps (no longer used by the harness).test/test_groups.tomlunchanged.Verified locally (
Pkg.test): GROUP=Core passes on Julia 1.11 (6 testsets, incl. Public) and on 1.10 LTS (5 testsets, Public correctly skipped); GROUP=QA passes on 1.11 (11/11, exercising the sub-env activation path).Supersedes #158 (the @safetestset canonicalization), which is folded into this PR.
Ignore until reviewed by @ChrisRackauckas.