Use SciMLTesting v1.0.0 (run_tests harness)#297
Open
ChrisRackauckas-Claude wants to merge 1 commit into
Open
Conversation
Convert test/runtests.jl from the hand-written GROUP if-ladder to a single
SciMLTesting.run_tests call. Behavior-equivalent: the set of tests run under
each GROUP value is identical to the previous dispatcher.
* core = Core testset (qa.jl, basics, sensitivity, ensemble, threshold,
examples) -- QA is folded into Core exactly as upstream main.
* groups = Dict("Datafit" => datafit.jl).
* all = ["Core", "Datafit"] -- the curated v1.1.0 membership reproducing
the original All branch (Core then Datafit; no separate QA group
ever existed here).
Project.toml: add SciMLTesting (uuid 09d9d899-5365-40a9-917a-5f67fddea283,
[compat] "1") to [extras] + test target. No Pkg to drop (upstream test deps
never included Pkg).
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a3b4816 to
acdd541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hand-written
GROUP-dispatch intest/runtests.jlwith a single declarativeSciMLTesting.run_testscall (SciMLTesting v1.0.0).This is a pure, behavior-equivalent harness refactor — same group routing and same test bodies, just driven by
run_testsinstead of a copy-pastedif GROUP == ...ladder.Routing:
core= theCoretestset (qa/basics/sensitivity/ensemble/threshold/examples, run in the main test env);groups["Datafit"]=datafit.jl(no sub-env, so it also runs under"All"). NoPkgwas present in the test deps, so none was removed.Project.toml: add
SciMLTestingto[extras],[targets].test, and[compat](= "1").Verified statically (TOML parse +
Meta.parseallofruntests.jl) and the dispatch was checked against the realrun_testswith marker thunks to confirm eachGROUPselects the same bodies as before. Heavy suites left to CI.Ignore until reviewed by @ChrisRackauckas.