Skip to content

QA: run_qa v1.6 form + ExplicitImports #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

QA: run_qa v1.6 form + ExplicitImports #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ PrecompileTools = "1"
Printf = "1.10"
Random = "1"
SafeTestsets = "0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
SparseArrays = "1.10"
StaticArrays = "1.9.8"
Test = "1"
Expand Down
2 changes: 1 addition & 1 deletion src/ExponentialUtilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module ExponentialUtilities
using LinearAlgebra, SparseArrays, Printf
using ArrayInterface: ismutable, allowed_getindex, allowed_setindex!
using ArrayInterface: ismutable, allowed_setindex!
using PrecompileTools
import GenericSchur
import GPUArraysCore
Expand Down
16 changes: 13 additions & 3 deletions src/exp_noalloc.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,19 @@ function alloc_mem(A, ::ExpMethodHigham2005)
end

# Import the generated code
for i in 1:13
include("exp_generated/exp_$i.jl")
end
include("exp_generated/exp_1.jl")
include("exp_generated/exp_2.jl")
include("exp_generated/exp_3.jl")
include("exp_generated/exp_4.jl")
include("exp_generated/exp_5.jl")
include("exp_generated/exp_6.jl")
include("exp_generated/exp_7.jl")
include("exp_generated/exp_8.jl")
include("exp_generated/exp_9.jl")
include("exp_generated/exp_10.jl")
include("exp_generated/exp_11.jl")
include("exp_generated/exp_12.jl")
include("exp_generated/exp_13.jl")

function getmem(cache, k) # Called from generated code
return cache[k - 1]
Expand Down
8 changes: 4 additions & 4 deletions test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[sources]
ExponentialUtilities = {path = "../.."}

[compat]
Aqua = "0.8"
JET = "0.9, 0.10, 0.11"
SafeTestsets = "0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"

[sources]
ExponentialUtilities = {path = "../.."}
86 changes: 34 additions & 52 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,34 @@
using ExponentialUtilities, Aqua, JET, Test

@testset "Aqua" begin
Aqua.find_persistent_tasks_deps(ExponentialUtilities)
Aqua.test_ambiguities(ExponentialUtilities, recursive = false)
Aqua.test_deps_compat(
ExponentialUtilities,
ignore = [:libblastrampoline_jll]
)
Aqua.test_piracies(ExponentialUtilities)
Aqua.test_project_extras(ExponentialUtilities)
Aqua.test_stale_deps(ExponentialUtilities)
Aqua.test_unbound_args(ExponentialUtilities)
Aqua.test_undefined_exports(ExponentialUtilities)
end

@testset "JET static analysis" begin
@testset "expv" begin
rep = JET.report_call(expv, (Float64, Matrix{Float64}, Vector{Float64}))
@test length(JET.get_reports(rep)) == 0
end

@testset "arnoldi" begin
rep = JET.report_call(arnoldi, (Matrix{Float64}, Vector{Float64}))
@test length(JET.get_reports(rep)) == 0
end

@testset "phi" begin
rep = JET.report_call(phi, (Matrix{Float64}, Int))
@test length(JET.get_reports(rep)) == 0
end

@testset "exponential!" begin
rep = JET.report_call(ExponentialUtilities.exponential!, (Matrix{Float64},))
@test length(JET.get_reports(rep)) == 0
end

@testset "phiv" begin
rep = JET.report_call(phiv, (Float64, Matrix{Float64}, Vector{Float64}, Int))
@test length(JET.get_reports(rep)) == 0
end

@testset "kiops" begin
rep = JET.report_call(kiops, (Float64, Matrix{Float64}, Vector{Float64}))
@test length(JET.get_reports(rep)) == 0
end

@testset "expv_timestep" begin
rep = JET.report_call(expv_timestep, (Float64, Matrix{Float64}, Vector{Float64}))
@test length(JET.get_reports(rep)) == 0
end
end
using SciMLTesting, ExponentialUtilities, JET, Test

run_qa(
ExponentialUtilities;
explicit_imports = true,
aqua_kwargs = (; deps_compat = (; ignore = [:libblastrampoline_jll])),
ei_kwargs = (;
# Names owned elsewhere but reached through LinearAlgebra.BLAS.
all_qualified_accesses_via_owners = (;
ignore = (:BlasFloat, :chkstride1, :libblastrampoline),
),
# Non-public names of Base / LinearAlgebra(.BLAS/.LAPACK) accessed qualified.
all_qualified_accesses_are_public = (;
ignore = (
Symbol("@aliasscope"), Symbol("@assume_effects"),
Symbol("@blasfunc"), Symbol("@propagate_inbounds"),
:BlasFloat, :Cartesian, :Const, :Experimental,
:checksquare, :chkfinite, :chklapackerror, :chkstride1,
:gebal!, :gesv!, :libblastrampoline, :rcswap!, :stegr!,
),
),
# Non-public names explicitly imported from LinearAlgebra(.BLAS/.LAPACK,
# incl. the Stegr submodule) / ArrayInterface / Base.
all_explicit_imports_are_public = (;
ignore = (
:BlasInt, :checksquare, :allowed_setindex!, :ismutable, :typename,
Symbol("@blasfunc"), :stegr!,
),
),
),
# Heavy `using LinearAlgebra, SparseArrays, Printf, PrecompileTools` brings ~31
# names implicitly; making them explicit is a large refactor tracked separately.
ei_broken = (:no_implicit_imports,)
) # SciML/ExponentialUtilities.jl#231
Loading