Fix Format Check: format FastPowerEnzymeExt.jl (SciMLStyle)#56
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Fix Format Check: format FastPowerEnzymeExt.jl (SciMLStyle)#56ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
The Format Check CI (SciML/.github format-check.yml@v1, JuliaFormatter v2
SciMLStyle) was red on main because ext/FastPowerEnzymeExt.jl was not
formatted. Applying `format(".", SciMLStyle())` only touches this one file;
re-running afterward reports the tree as already formatted. Purely cosmetic;
no semantic change.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Format Check / Check Formattingjob onmainwas failing. That job runs the SciML shared workflowSciML/.github/.github/workflows/format-check.yml@v1, which applies JuliaFormatter v2 withSciMLStyle()and fails if any file changes.Locally reproduced on Julia 1.12 (the "1" channel) with JuliaFormatter v2.8.0:
The only unformatted file was
ext/FastPowerEnzymeExt.jl(the@easy_rulemacro call argument layout). This PR applies the canonical formatting. Re-running the formatter afterward reports the tree as already formatted (true), so the Format Check will pass. The change is purely cosmetic with no semantic effect.Note: the other red checks on
mainare downstream tests (OrdinaryDiffEq.jl, SimpleDiffEq.jl) which are out of scope for this repo's own CI.Local verification
julia +1.12with JuliaFormatter v2.8.0 + SciMLStyle: before = needs change (only this file), after = already formatted.Please ignore until reviewed by @ChrisRackauckas