Skip to content

Use SciMLTesting v1.2 (folder-based run_tests)#57

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:canonicalize-safetestset
Jun 14, 2026
Merged

Use SciMLTesting v1.2 (folder-based run_tests)#57
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:canonicalize-safetestset

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Converts test/runtests.jl to the SciMLTesting v1.2 folder-discovery model:

using SciMLTesting
run_tests()

Layout

  • Core — the inline GROUP in ("All","Core") block from runtests.jl is extracted into a self-contained top-level test/core_tests.jl (with its own using FunctionProperties, ComponentArrays, Random, Test). Core = top-level test/*.jl, run in the main test env.
  • QAtest/qa/qa.jl + test/qa/Project.toml, activated automatically by folder discovery.
  • test/test_groups.toml is unchanged (Core, QA).

Deps

  • Root [extras]/[targets].test + [compat]: add SciMLTesting; keep SafeTestsets/Test/ComponentArrays/Random; drop the unused Pkg test extra (the v1.2 harness owns all Pkg operations).
  • test/qa/Project.toml: add SciMLTesting + SafeTestsets; drop Pkg.

Verification

Behavior-preserving. Ran locally on Julia 1.11 via Pkg.test:

This supersedes the earlier @safetestset canonicalization on this branch (which would have changed Core to a Lux-based formulation — a behavior change this conversion deliberately avoids).

Ignore until reviewed by @ChrisRackauckas.

Convert test/runtests.jl to the SciMLTesting v1.2 folder-discovery model:
`using SciMLTesting; run_tests()`. The inline Core test block is extracted
to a self-contained top-level test/core_tests.jl (Core group). QA stays in
test/qa/ with its own Project.toml. Behavior-preserving: GROUP=Core, GROUP=QA,
and GROUP=All run exactly the same tests as before.

Adds SciMLTesting + SafeTestsets to the root test deps and the QA sub-env;
drops the now-unused Pkg test extra (the v1.2 harness owns all Pkg ops).
test/test_groups.toml is unchanged.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Canonicalize tests to @safetestset for module isolation Use SciMLTesting v1.2 (folder-based run_tests) Jun 14, 2026
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Rebuilt this branch as the SciMLTesting v1.2 folder conversion (reset to upstream/main, then rebuilt the folder form). The Core block is now extracted to a self-contained test/core_tests.jl (preserving the explicit-affine formulation, not the Lux one), and runtests.jl is using SciMLTesting; run_tests(). Verified locally on Julia 1.11: GROUP=Core (10 pass), GROUP=All (10 pass), GROUP=QA (7 pass / 2 broken) all match master behavior.

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 14, 2026 23:54
@ChrisRackauckas ChrisRackauckas merged commit 7d6010a into SciML:main Jun 14, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants