Skip to content

Use SciMLTesting v1.2 (folder-based run_tests)#73

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:canonicalize-safetestset
Jun 14, 2026
Merged

Use SciMLTesting v1.2 (folder-based run_tests)#73
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:canonicalize-safetestset

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Converts the test suite to the SciMLTesting v1.2 model, replacing the hand-written GROUP dispatcher in test/runtests.jl with a single declarative run_tests(...) call.

  • runtests.jl now uses using SciMLTesting; run_tests(...).
  • Core (test/core_tests.jl + test/explicit_imports_test.jl) runs in the main test environment for GROUP=All and GROUP=Core.
  • NoPre (JET + AllocCheck) moved to test/NoPre/ (renamed from test/nopre/) with its own Project.toml; it runs only for GROUP=NoPre, never as part of All — preserved via the curated all = ["Core"].
  • test/test_groups.toml is unchanged.
  • Dependency edits: added SciMLTesting + SafeTestsets to the root test target (dropped Pkg, which only the old harness used) and to test/NoPre/Project.toml.

Behavior-preserving: the exact set of tests run under each GROUP value (All / Core / NoPre) is unchanged; verified by driving run_tests over every group value.

Ignore until reviewed by @ChrisRackauckas.

Replace the hand-written GROUP dispatcher with SciMLTesting's run_tests.
Core (core_tests.jl + explicit_imports_test.jl) runs in the main test env for
All/Core; NoPre (JET + AllocCheck) runs in its own test/NoPre sub-env only for
GROUP=NoPre. test_groups.toml is unchanged; the curated all=["Core"] keeps NoPre
out of "All", preserving the original per-GROUP test set exactly.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Canonicalize tests to @safetestset for isolation Use SciMLTesting v1.2 (folder-based run_tests) Jun 14, 2026
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 14, 2026 23:54
@ChrisRackauckas ChrisRackauckas merged commit 86d291b into SciML:master Jun 14, 2026
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants