Use SciMLTesting v1.2 (folder-based run_tests)#607
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Use SciMLTesting v1.2 (folder-based run_tests)#607ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Convert the test suite to SciMLTesting v1.2. JumpProcesses has GPU-only groups (CUDA, Correctness) that are not declared in test_groups.toml and are run by a separate GPU.yml workflow against the gpu/ sub-environment, so the bare folder-discovery mode cannot express them. This uses the explicit-args run_tests form over a folder layout instead. Folder layout: - test/InterfaceI/ : the 21 files GROUP=InterfaceI ran (top-level moves). - test/InterfaceII/ : the 18 files GROUP=InterfaceII ran, including the former test/spatial/*.jl (flattened; each is self-contained). - test/qa/qa.jl : the QA body (runs in the root test env; Aqua + ExplicitImports live in the root [extras]). - test/gpu/ : unchanged (CUDA env). - test/shared/run_spatial_tests.jl : the unused manual spatial driver, parked out of the group folders (never run by runtests.jl). runtests.jl becomes a single run_tests(...) call: - groups = InterfaceI / InterfaceII / CUDA / Correctness thunks. The CUDA and Correctness thunks keep activate_gpu_env() verbatim. - qa = test/qa/qa.jl. - all = ["InterfaceI", "InterfaceII"] (curated; matches the old All = InterfaceI + InterfaceII, with QA/CUDA/Correctness excluded). Each Interface thunk keeps the original @safetestset labels and run order, only updating the include paths to the new folders. The set of tests run under each GROUP value (All, InterfaceI, InterfaceII, QA, CUDA, Correctness) is unchanged. test/test_groups.toml is untouched. Deps: add SciMLTesting to root [extras]/[targets].test and [compat]. Pkg is retained (activate_gpu_env still uses it). SafeTestsets/Test already present. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Please hold,off on this till the JumpProcesses 10 changes are merged. This will,be a mess to reconcile with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the JumpProcesses.jl test suite to the SciMLTesting v1.2 model.
Why explicit-args (not bare folder-discovery)
JumpProcesses has GPU-only groups (
CUDA,Correctness) that are not declared intest_groups.tomland are run by a separateGPU.ymlworkflow against thetest/gpu/sub-environment (viaactivate_gpu_env). SciMLTesting's bare folder-discovery (run_tests()) errors on aGROUPvalue that is not intest_groups.tomland cannot activate the GPU env per-group, so it cannot express these. There is also noCoregroup (All = InterfaceI + InterfaceII), which folder-discovery's mandatory non-empty Core would conflict with. This PR therefore uses the explicit-argsrun_tests(...)form over a folder layout (same pattern as the OrdinaryDiffEq.jl conversion).Folder layout
test/InterfaceI/— the 21 filesGROUP=InterfaceIran.test/InterfaceII/— the 18 filesGROUP=InterfaceIIran, including the formertest/spatial/*.jl(flattened; each file is self-contained).test/qa/qa.jl— the QA body (runs in the root test env; Aqua + ExplicitImports are in the root[extras]).test/gpu/— unchanged (CUDA env).test/shared/run_spatial_tests.jl— the unused manual spatial driver, parked out of the group folders (never run byruntests.jl).runtests.jl
A single
run_tests(...)call:groups=InterfaceI/InterfaceII/CUDA/Correctnessthunks. TheCUDAandCorrectnessthunks keepactivate_gpu_env()verbatim.qa = test/qa/qa.jl.all = ["InterfaceI", "InterfaceII"]— curated, matching the oldAll = InterfaceI + InterfaceII(QA/CUDA/Correctness excluded).Each Interface thunk preserves the original
@safetestsetlabels and run order, updating only the include paths to the new folders.Behavior preservation
The set of tests run under each
GROUPvalue (All,InterfaceI,InterfaceII,QA,CUDA,Correctness) is unchanged;test/test_groups.tomlis untouched. The dispatch was verified to fire exactly the same group bodies as the oldif GROUP == ...ladder. Verified end-to-end on Julia 1.11:GROUP=QApasses 11/11 viaPkg.test().Deps
Add
SciMLTestingto root[extras]/[targets].test/[compat].Pkgis retained (activate_gpu_envstill uses it).SafeTestsets/Testwere already present.Ignore until reviewed by @ChrisRackauckas.