Throw clear ArgumentError for grids too coarse for boundary stencil#578
Open
SAY-5 wants to merge 1 commit into
Open
Throw clear ArgumentError for grids too coarse for boundary stencil#578SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Contributor
|
This looks much better. I've closed my PR since this is a cleaner approach. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #559. On a non-uniform grid with fewer than approximation_order + 1 points, the boundary extrapolator indexed dx out of range and failed with an opaque BoundsError deep in extrapolation_weights.jl. This adds an explicit length check up front so the user gets a clear message telling them the grid is too coarse for the boundary stencil. Added a regression test alongside the existing non-uniform convection cases.