QA: restore Aqua deps_compat (add missing [compat] for test extras)#84
Merged
ChrisRackauckas merged 1 commit intoJun 13, 2026
Merged
Conversation
The grouped-tests-ci conversion added `Pkg` to [extras]/[targets].test without a corresponding [compat] entry, which makes the extras sub-check of Aqua.test_deps_compat fail. That was worked around by passing check_extras=false and adding a `@test_broken false` sentinel pointing at issue SciML#83 — hiding the metadata gap instead of fixing it. This adds the one-line metadata fix `Pkg = "1"` to [compat] and removes the check_extras=false weakening plus the sentinel, restoring the full Aqua.test_deps_compat(PoissonRandom). All other QA checks are unchanged. Verified locally with GROUP=QA on julia 1.11: Aqua 10/10, JET 6/6, ExplicitImports 2/2, zero broken, zero failures. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The grouped-tests-ci conversion (#82) added
Pkgto[extras]/[targets].testbut did not add a matching[compat]entry. That makes the extras sub-check ofAqua.test_deps_compatfail (Pkghas no compat bound). Instead of the one-line metadata fix, the QA driver worked around it by passingcheck_extras = falseand adding a@test_broken falsesentinel pointing at #83 — which hides the metadata gap and disables a real check.This restores proper CI hygiene:
Pkg = "1"to[compat]in the rootProject.toml. (Every other[extras]dep already has a compat entry.)test/qa/qa.jl, dropcheck_extras = falseand the@test_broken falsesentinel, restoring the fullAqua.test_deps_compat(PoissonRandom).No test logic, assertions, or algorithm behavior changed. No package
[compat]lower bound was loosened.Local verification
GROUP=QAon julia 1.11 (Pkg.test()):Zero broken, zero failures — the full
test_deps_compat(deps + extras + weakdeps) now runs clean.Closes #83 (that issue tracked only this deps_compat nit).
Ignore until reviewed by @ChrisRackauckas.