feat(e2e): add some playwright e2e tests#99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds E2E tests (manually run)
Now that we have the e2e test pattern established, it should be easy to add more and maintain them using any competent coding agent with browser-use capability (personally I used Hermes Agent + GLM 5.2). The
e2e/README.mdfile describes the easiest way to run, create, and maintain e2e tests.Playwright and browser is installed inside the devcontainer so it should just work with
npm run test:e2e, as long as theE2E_BASE_URLpoints to the correct running instance to test. You might need to rebuild your devcontainer for this to work. Let me know if any issues.In this PR, they don't run as part of github workflows. EDIT: this has since been added in a followup PR: #100
The coverage of these tests is basic (e.g. doesn't test sign-in and publish) but it can be expanded easily and will help to protect against regression.