feat(links): optional chain icon after hyperlinks#89
Merged
Conversation
Contributor
Author
|
@SeardnaSchmid Ready for review |
Owner
|
I think you can make it the default. Thanks 👍 |
Contributor
|
Lets wait for #84 to be merged, then audit should be green |
IrishBruse
force-pushed
the
link-emoji-toggle
branch
from
47ce362 to
cda53f7
Compare
Contributor
|
@SeardnaSchmid pleade merge #94 first |
Contributor
|
needs a rebase, sorry forgot you base on me :/ |
IrishBruse
force-pushed
the
link-emoji-toggle
branch
from
cda53f7 to
d46d773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
markdownInlineEditor.links.showEmoji(defaultfalse) to toggle the chain (🔗) suffix on decorated links. Recreates link decoration when the setting changes.I personally think this should be off by default but im willing to swap it.
Closes #87
Rebased onto #94