docs: add conventional commits guide#47
Conversation
Bashir3355
left a comment
There was a problem hiding this comment.
documentation added and looks good.
Waiting for the approval to be completed or merged.
DS-0277
left a comment
There was a problem hiding this comment.
The description looks great. Good job!
|
Reviewed the PR. The Issue Creation Guide content itself is well-written — However, I noticed a mismatch between the PR metadata and the actual file Could you clarify whether:
Also noticed the failing checks (Auto-assign and Sync Project Status). Once Content LGTM, just needs the metadata cleaned up. |
|
Reviewed the PR. The documentation is well structured and easy to follow. The setup steps are clear and logically ordered. Code changes align with the PR description and are easy to understand. One suggestion: ensure that the PR title matches the exact content of the files being changed to avoid confusion during review. Overall, this looks good and meets the expected requirements. |
|
Good effort on this guide! A few things I noticed:
Worth aligning with the existing wiki page before merging to avoid confusion. |
ErmiyasHailemichael
left a comment
There was a problem hiding this comment.
- The PR title says "conventional commits guide" but the content is actually an Issue Creation guide — these don't match.
- The wiki already has an Issue Creation page with more detail. This version is missing some sections like naming conventions and sprint assignment.
- Small grammar fix needed: "Provide screenshots or examples this will be helpful" should be "Provide screenshots or examples if applicable."
Added documentation referencing Conventional Commits to the Practicum Wiki to guide students on writing standardized commit messages.
Includes:
feat,fix, anddocsFixes #45