Skip to content

SeattleColleges-AD-Practicum-Wiki_44_documentation-team-directory-page#52

Open
ErmiyasHailemichael wants to merge 2 commits into
mainfrom
documentation/team-directory-page-issue44
Open

SeattleColleges-AD-Practicum-Wiki_44_documentation-team-directory-page#52
ErmiyasHailemichael wants to merge 2 commits into
mainfrom
documentation/team-directory-page-issue44

Conversation

@ErmiyasHailemichael

Copy link
Copy Markdown

Summary & Changes 📃

  • Resolves: #44
  • Summary:
    • 🔨 The Team Directory wiki page existed but had no content ("coming soon!"). This PR adds the full page content.
    • 👀 The Team Directory page should display a structured table of program leadership and current students with GitHub profile links and active projects.
    • 🗨️ Content was added both to the wiki directly and mirrored in docs/team-directory.md for version control.
  • Changes:

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️ Screenshot 2026-05-12 at 9 31 30 PM

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: Navigate to the Team Directory wiki page
    • Step 2: Verify the page displays the leadership table, current students table, and update instructions
  2. Expected Behavior: A fully populated Team Directory page with structured tables and navigation links.

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #44).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

@ErmiyasHailemichael ErmiyasHailemichael linked an issue May 13, 2026 that may be closed by this pull request
2 tasks
@nsc-ad-projectstatus-bot nsc-ad-projectstatus-bot Bot moved this to In Progress in NSC AD Wiki May 13, 2026
@ErmiyasHailemichael ErmiyasHailemichael marked this pull request as ready for review May 13, 2026 04:36
@nsc-ad-projectstatus-bot nsc-ad-projectstatus-bot Bot moved this from In Progress to In Review in NSC AD Wiki May 13, 2026
@ching202

Copy link
Copy Markdown

Reviewed the Team Directory documentation updates and the organization looks clear and beginner-friendly. The added structure and contributor instructions improve readability and navigation throughout the wiki.

@josehorta21 josehorta21 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Team Directory page. Thanks @ErmiyasHailemichael for tackling
this — and also for the thoughtful feedback you left on my Onboarding
Guide PR (#50) earlier this week.

The structure is well-organized — Program Leadership, Current Students
table, How to Update This Page, and Navigation links all flow logically
and make the page easy to scan. A few specific observations from the diff:

  1. Placeholder rows in the Current Students table (lines 22–24). Three
    rows contain *(Your Name)* with @yourusername placeholders. Are
    these intentional template rows showing contributors how to format their
    entries, or were they meant to be removed before review? If they're
    meant as a template, it might be cleaner to move them into the "How to
    Update This Page" section as a code-formatted example so the actual
    table only shows real contributors.

  2. Navigation links should be verified. The footer links to wiki pages
    like /wiki/New-Student-Onboarding, /wiki/Guides-and-Resources,
    /wiki/Active-Projects, /wiki/Code-of-Conduct, and /wiki/FAQ. Worth
    confirming each of these wiki pages exists, otherwise contributors will
    hit broken links from the directory.

  3. File location consistency. The file lives at docs/team-directory.md,
    while my in-progress Onboarding Guide (#50) sits at
    Onboarding/Onboarding-Guide.md. The repo seems to be evolving toward
    topic-named folders (Onboarding/, Issue-Creation/, belindas-closet/).
    No blocker for this PR, but worth aligning on a convention
    (docs/ vs topic-folder) at the team level so future docs stay
    predictable.

  4. +1 to @ching202's comment that the structure improves readability and
    navigation. Having a single source of truth for who's contributing
    what really helps onboarding.

  5. "How to Update This Page" section is a nice touch. Concrete steps
    for adding a new row make this self-service for contributors — much
    better than asking a maintainer to update the page every time someone
    joins.

One small suggestion for the table itself: consider adding a "Role" or
"Track" column with finer granularity (e.g., Frontend Dev, Backend Dev,
Documentation, PM) since "Developer | TBD" is fairly broad for a directory
meant to help people find who's working on what.

Overall a solid addition. Main thing to clarify before merge is the intent
of the placeholder rows.

Updated the Current Students table format to include a 'Track' column and modified instructions accordingly.
@ErmiyasHailemichael

Copy link
Copy Markdown
Author

Thanks for the detailed feedback!

Here's what I updated based on your review:

  • Placeholder rows removed from the Current Students table and moved into the "How to Update This Page" section as a code-formatted example, so the table only shows real contributors.
  • Added a "Track" column to the Current Students table with example values (Frontend Dev, Backend Dev, Documentation, PM) for more granularity.
  • Verified navigation links — I'll flag any broken ones as a follow-up if needed.

Regarding file location consistency (docs/ vs topic-folder), I agree that's worth aligning on as a team — happy to bring it up in our next sync.

Let me know if anything else needs adjusting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Issue: Team Directory Page

3 participants