Skip to content

seattlecolleges.github.io_issue#122_add-rae-maffei-to-students#129

Merged
IsaacJrTypes merged 3 commits into
SeattleColleges:mainfrom
givecoffee:add-student-rae-maffei
Mar 26, 2026
Merged

seattlecolleges.github.io_issue#122_add-rae-maffei-to-students#129
IsaacJrTypes merged 3 commits into
SeattleColleges:mainfrom
givecoffee:add-student-rae-maffei

Conversation

@givecoffee

@givecoffee givecoffee commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Added new student entry for Rae Maffei with details.

Summary & Changes 📃

  • Resolves: Students Page: Add yourself to the Students Page #122

  • Summary: (Briefly describe what this PR does)

    • Adds new student entry to src/students.json
    • Maintained proper JSON syntax
    • Follows required formatting
    • Added entry to the end of list without modifying existing entries

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: Pull this branch locally
    • Step 2: Verify src/students.json has valid JSON syntax
    • Step 3: Run the application locally
    • Step 4: Navigate to the Students section
    • Step 5: Confirm Rae Maffei's profile appears correctly
  2. Expected Behavior: New student card displays with all information properly formatted
  3. Actual Behavior (if bug): N/A

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #issue-number).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

Added new student entry for Rae Maffei with details.
@SUPER444E

Copy link
Copy Markdown
Contributor

light flag on this PR for naming convention , please check documentation below

https://github.com/SeattleColleges/SeattleColleges-AD-Practicum-Wiki/wiki/draft-and-regular-prs

@IsaacJrTypes IsaacJrTypes changed the title <!-- seattlecolleges.github.io_[issue#122]_add-rae-maffei-to-students --> seattlecolleges.github.io_[issue#122]_add-rae-maffei-to-students Mar 4, 2026
@IsaacJrTypes IsaacJrTypes changed the title seattlecolleges.github.io_[issue#122]_add-rae-maffei-to-students seattlecolleges.github.io_issue#122_add-rae-maffei-to-students Mar 4, 2026
@IsaacJrTypes

Copy link
Copy Markdown
Contributor

Hi @givecoffee! Is this PR meant to be in draft or is it ready to be merged? You have all the basic required data for the student's page added, but I didn't see you include a profile picture in the image asset folder. If you are ok with the anon profile pick, let me know and I can get this merged

@IsaacJrTypes IsaacJrTypes marked this pull request as draft March 4, 2026 19:19
@IsaacJrTypes

Copy link
Copy Markdown
Contributor

I also placed the PR into a draft for now. Open it back up for merging if you are done with the PR.

@sstar691969 sstar691969 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

students.json code or developer profile looks good. brackets and commas look greated. no errors from my view. If your having issue with profile photo BC shared that profile photo is not needed currently to move forward on submitting.

@sstar691969

Copy link
Copy Markdown
Contributor

Attention: your PR is in "Drafted" as mentioned by IssacJrType.

@bcko

bcko commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

@givecoffee Once you are ready, can you turn this into ready state?

@bcko bcko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Make sure to turn your PR from draft to ready.

@givecoffee givecoffee marked this pull request as ready for review March 20, 2026 07:03
@SeattleColleges SeattleColleges deleted a comment from sstar691969 Mar 26, 2026

@IsaacJrTypes IsaacJrTypes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR, thank you for properly filling out the PR description!

@IsaacJrTypes IsaacJrTypes merged commit 53cead9 into SeattleColleges:main Mar 26, 2026
2 checks passed
@sstar691969

sstar691969 commented Mar 26, 2026 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants