chore: temporarily disable disambiguation logic in tasks.py#3208
Open
nsantacruz wants to merge 77 commits intoprodfrom
Open
chore: temporarily disable disambiguation logic in tasks.py#3208nsantacruz wants to merge 77 commits intoprodfrom
nsantacruz wants to merge 77 commits intoprodfrom
Conversation
BREAKING CHANGE: Used pip-compile to create the new file
…with Topic.slug being promoted to PrimaryKey
…lugin in-repo (package already removed from requirements.txt)
…being called before the Apps registry is initialized
…being called before the Apps registry is initialized
- Resolved conflicts in django_topics/migrations/0003_auto_20241121_0757.py - Resolved conflicts in requirements.txt, keeping compiled structure with updated versions - Updated to newer versions: celery[redis]==5.5.2, pymongo==4.13.*, redis==5.2.1 - Added new packages from master: gevent, google-analytics-data, LLM interface - Maintained compiled pip-tools format while incorporating master changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…go-2-0' into feature/sc-31678/upgrade-to-django-2-0
…-39065/upgrade-to-django-2-x-on-mdl Resolved conflicts in: - reader/templatetags/sefaria_tags.py: Combined import statements and kept static file hash function from HEAD - requirements.txt: Kept Django 2.2 and related packages from merging branch - sefaria/urls.py: Kept minimal URLconf for django-hosts setup - templates/base.html: Combined DJANGO_VARS with contentLang, static_url, and module_mapping This merge brings in: - Django 2.0/2.2 compatibility updates - Fixed circular import in sefaria_tags.py - emailusernames authentication backend - API testing infrastructure (test_api_endpoints.py, analyze_api_errors.py) - Various model and helper updates for Django 2.x 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ngo 2.0+ In Django 2.0+, monkey patching at module import time can have timing issues with the app loading system. This moves the User model monkey patch to an AppConfig.ready() method, which is the recommended approach for Django 2.0+. Changes: - Add emailusernames/apps.py with EmailUsernamesConfig - Update __init__.py to set default_app_config - Remove module-level monkeypatch_user() call from models.py - Add _patched guard to prevent double-patching - Add unit tests for monkey patch functionality Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…t framework Django's test database creation can overwrite User.__dict__['__init__'] with Model.__init__, removing our monkey patch. The fix detects when this happens and re-applies the patch. Also removes deprecated this_is_the_login_form handling from login template and adds comprehensive tests for the monkey patching behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 4e6aacf.
Decreased the size limit for the shared volume and ephemeral storage requests from 50Gi to 40Gi in the text-export CronJob configuration to optimize resource usage.
…uite Replaced Playwright/TypeScript API tests with pytest/requests equivalents. 49 tests covering texts, search, sheets, topics, calendars, health, profile/auth, and core endpoints. No Django dependency — tests hit HTTP endpoints and can run against any Sefaria instance. Usage: cd api-tests API_BASE_URL=https://www.django-upgrade.cauldron.sefaria.org python -m pytest -v Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… request.LANGUAGE_CODE is always "en" for APIs
…ew-calendar-items
Adds a promotion-gate workflow that blocks PRs into preprod/prod unless they come from an allowed source branch (master→preprod, preprod→prod, hotfix/*→either). Also adds promote-to-preprod and promote-to-prod jobs to deploy-static.yaml, gated by GitHub environment reviewers, plus a changelog-generating script for promotion PRs. Relates to sc-43330 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- preprod PRs: rollback reference (current app+chart versions) + commits - prod PRs: AI summary (claude-haiku) + rollback reference + commits - prod Slack message: includes AI summary and rollback version - Rollback versions read from target branch helmrelease.yaml via git show - ANTHROPIC_API_KEY is optional; graceful fallback if unset or API fails Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-link-to-a-commentator-and-it fix: don't queryselectorall using exact string
…ngo-2-x-on-mdl Upgrade to Django 2.x on Modularization
preprod promotion only needs commits list — no AI summary, no API key. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove auto-promotion jobs from deploy-static.yaml — they ran on every push to master/preprod and would create a PR (or reviewer prompt) on each merge, spamming reviewers who only promote once per sprint. Add manual-promotion.yaml (workflow_dispatch) that creates the promotion PR on demand. Includes AI summary + Slack notification for prod targets. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Aligns with demo repo pattern. Without origin/ prefix, git log compares local tracking branches which may be stale on a fresh checkout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fetch target+source refs before git show/log — checkout with fetch-depth:0 doesn't guarantee remote branch refs are present, causing rollback read and changelog to silently fail - Use toJson(format(...)) on all Slack payload interpolations to correctly escape quotes/newlines (e.g. in AI summary) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
promotion-gate.yaml: - Guard against empty SOURCE/TARGET refs (merge_group edge case) - Add else/exit 1 for unknown target branches (gate falls open) manual-promotion.yaml: - Pass workflow_dispatch inputs via env vars, not inline interpolation (prevents script injection via direct API triggers) generate-promotion-pr.sh: - git fetch logs warning on failure instead of silently swallowing - git log fails loudly — distinguishes missing refs from no commits - Rollback version failures log warnings before falling back to unknown - AI summary: capture HTTP status code, log non-200 responses visibly - AI summary: use heredoc format for GITHUB_OUTPUT to handle newlines - PR "already exists": retrieve actual PR URL via gh pr view Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat: branch protection + promotion gate for preprod and prod
Reject /api/texts/<book>?commentary=1&pad=0 for book-level refs, which would otherwise expand links across the entire book. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…'s precededent below, return the correct code.
…t_out_of_order method
feat: add method to check non-NAMED part matching order in multi-part…
…ew-calendar-items
…t-show-hebrew-calendar-items bug/sc-43328/hebrew-site-doesn-t-show-hebrew-calendar-items
chore: guard texts_api against whole-book commentary+pad=0 requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here