Skip to content

Fix index from queue#3261

Open
nsantacruz wants to merge 2 commits intomasterfrom
fix-index-from-queue
Open

Fix index from queue#3261
nsantacruz wants to merge 2 commits intomasterfrom
fix-index-from-queue

Conversation

@nsantacruz
Copy link
Copy Markdown
Contributor

Description

Fix a syntax error that was preventing index from queue from running properly.
In the process, removed old elasticsearch DSL library and upgraded elasticsearch because it now includes the DSL library.

@gitvelocity-reviewer
Copy link
Copy Markdown

📊 Code Quality Score: 7/100

27 × 0.25 (Micro ESF) = 6.75, rounded to 7

Category Score Factors
🔭 Scope 5/20 2 files with meaningful logic changes, touches critical search indexing subsystem; no new endpoints or APIs
🏗️ Architecture 6/20 Removes fragile fork dependency in favor of official package; positive supply chain improvement; no new abstractions introduced
⚙️ Implementation 5/20 Straightforward API migration with keyword argument updates; put_mapping semantic change (full body → properties only) requires care but is low complexity
⚠️ Risk 8/20 Search indexing is a critical production path; 10-minor-version jump may have unaudited breaking changes; no feature flag; silent failure modes in except blocks; no rollback plan documented
✅ Quality 2/15 No tests added for any changed code paths; no documentation of API changes or changelog review; 0% coverage on modified lines
🔒 Perf / Security 1/5 Removes supply chain risk from GitHub-hosted fork dependency; no performance or security analysis otherwise

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant