Feature/sc 43297/migrate welcome messages from remoteconfig#3265
Open
stevekaplan123 wants to merge 5 commits intomasterfrom
Open
Feature/sc 43297/migrate welcome messages from remoteconfig#3265stevekaplan123 wants to merge 5 commits intomasterfrom
stevekaplan123 wants to merge 5 commits intomasterfrom
Conversation
…from-remoteconfig
…rings-to-language
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Django-side RemoteConfig-backed “chatbot welcome messages” configuration and stops passing welcome message payloads from base_props into the lc-chatbot web component, relying instead on the chatbot UI’s own defaults and providing only interface language.
Changes:
- Stop sending
chatbot_welcome_messagesfromreader.views.base_props()and stop passingwelcome-messagesinto<lc-chatbot>inReaderApp. - Remove the
CHATBOT_WELCOME_MESSAGESRemoteConfig key constant. - Remove the (now-unneeded)
chatbotDjango app (admin/proxy model) and drop it fromINSTALLED_APPS.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| static/js/ReaderApp.jsx | Removes welcome-messages prop passed to <lc-chatbot>; sets interface-lang via Sefaria._getShortInterfaceLang(). |
| reader/views.py | Removes import/prop wiring for chatbot_welcome_messages from base_props(). |
| remote_config/keys.py | Removes CHATBOT_WELCOME_MESSAGES key constant. |
| sefaria/settings.py | Removes chatbot from INSTALLED_APPS. |
| chatbot/models.py | Deleted: removes RemoteConfig proxy model + helper for welcome messages. |
| chatbot/admin.py | Deleted: removes custom singleton-style admin UI for editing welcome messages. |
| chatbot/apps.py | Deleted: removes Django app config for chatbot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…uage' into feature/sc-43297/migrate-welcome-messages-from-remoteconfig
Contributor
YishaiGlasner
left a comment
YishaiGlasner
left a comment
There was a problem hiding this comment.
that seems to include the other pr, so my comment is relevant here
Contributor
Author
I responded in the other PR. #3264 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the Django-side RemoteConfig-backed “chatbot welcome messages” configuration and stops passing welcome message payloads from
base_propsinto thelc-chatbotweb component, relying instead on the chatbot UI’s own defaults. Removes the (now-unneeded)chatbotDjango app (admin/proxy model) and drop it fromINSTALLED_APPS. The previous complicated setup is no longer necessary as the 3 welcome messages are now going to be in en.json/he.json in the chatbot repo. This PR should not be merged until #3264 and Sefaria/ai-chatbot#125 are merged.