Add values for bandwidth estimate computations#107
Merged
Conversation
Contributor
vikaskurapati
left a comment
vikaskurapati
left a comment
There was a problem hiding this comment.
Could you please also write (or make AI write) the relevant tests for it? We are then good to go.
AI-generated. Model: Opus 4.7
| inConstBytes = sum(size for size in inConstTensors.values()) | ||
| inBytes = sum(size for size in inTensors.values()) | ||
| outBytes = sum(size for size in outTensors.values()) | ||
|
|
Contributor
There was a problem hiding this comment.
Can we not directly write something like this:
Suggested change
| inConstBytes = sum(inConstTensors.values()) |
and similarly for the remaining two?
Contributor
There was a problem hiding this comment.
Nice, thanks for writing the test!
vikaskurapati
approved these changes
May 19, 2026
Contributor
vikaskurapati
left a comment
vikaskurapati
left a comment
There was a problem hiding this comment.
One minor comment. Can be ignored if it does not make sense. LGTM otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute the amount of memory transferred in/out by a kernel, in a similar vein to the FLOP counters.
Probably only really useful as an estimate (and only as an estimate) for the rough bandwidth in the GPU case, if we ignore any caching from previous kernels.